Skip to content

Conversation

@geimer
Copy link
Contributor

@geimer geimer commented Aug 17, 2020

Fixes #11105

@jhein32 Please test - works for me.

@jhein32
Copy link
Collaborator

jhein32 commented Aug 18, 2020

@geimer

Hi Markus.

The builds on our system using the --from-pr=11123 option. I can use the scorep to instrument a simple OpenMP test code, which wouldn't link without the patch. I can examine the resulting profile using the cube browser. No issues at all.

I am happy for the issue report #11105 to be closed.

Thanks for your effort.

@boegel
Copy link
Member

boegel commented Aug 19, 2020

@boegelbot please test @ generoso

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Aug 19, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3157.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/b1a4fad48d7d1f00d2cbd152017c4d88 for a full test report.

@boegel
Copy link
Member

boegel commented Aug 19, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2450.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/adbe92800413e7d714f0fa4f0a2fdffe for a full test report.

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11123 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11123 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5089

Test results coming soon (I hope)...

Details

- notification for comment with ID 676617558 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (1 easyconfigs in this PR)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/9b70c7ce4d48a77726e8de9409fb396e for a full test report.

@boegel
Copy link
Member

boegel commented Aug 19, 2020

Going in, thanks @geimer!

@boegel boegel merged commit 25d95d2 into easybuilders:develop Aug 19, 2020
@boegel
Copy link
Member

boegel commented Aug 19, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3416.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/0ee2302b054ba257d79a1ad6507416ea for a full test report.

@geimer geimer deleted the scorep6-fix_binutils_2.34_api_change branch August 20, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scorep 6.0 in gompi 2020a doesn't work with binutils 2.34

4 participants