-
Notifications
You must be signed in to change notification settings - Fork 772
Use pip to install protobuf-python in 2019b toolchain (requires re-downloading source tarball!) #11143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pip to install protobuf-python in 2019b toolchain (requires re-downloading source tarball!) #11143
Conversation
4bd07e6 to
d7f73a6
Compare
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 677652902 processed Message to humans: this is just bookkeeping information for me, |
|
Installation will fail if source tarball was downloaded with original easyconfig, but there's little we can do to prevent that... Easy to fix with |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Test report by @boegelbot |
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @Flamefire! |
(created using
eb --new-pr)The method of installing protobuf-python from the github (sub-)tree contained in the released protobuf-python.tar.gz requires using setup.py instead of pip and installs an egg folder instead of a "regular installation".
This conflicts with other google packages which install regular
site-packages/google/footrees resulting in protobuf not being found. This happens e.g. in TensorFlow when trying to use this EC.Additionally the C++ extension is not build causing decreased performance in some scenarios (not sure which, didn't dig deeper but it is mentioned prominently in their readme)
This PR makes it use the PyPI source release which is installable by pip because it contains precompiled protobuf files (pip install on the source tree fails due to relative paths)
Problem: As it makes sense to name the downloaded file
protobuf-python.tar.gz(via the template) it will yield in a wrong checksum if the EC was installed before and requires a forced redownload. IMO this is acceptable as the existing EC is relatively new and likely not used to often