Skip to content

use more EasyBuild installed dependencies for TensorFlow 2.2.0 #11224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 2 commits into from
Sep 25, 2020
Merged

use more EasyBuild installed dependencies for TensorFlow 2.2.0 #11224

boegel merged 2 commits into from
Sep 25, 2020

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Sep 7, 2020

Similar to #11109 this updates the TensorFlow 2.2.0 ECs to use more dependencies provided by EB

@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 7, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
taurusml4 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/4181e3504a2cf1957e4a6afd6a10c33b for a full test report.

@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 7, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
taurusa6 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz, Python 2.7.5
See https://gist.github.com/4bfcf5e175bea5737da20f82855f9af4 for a full test report.

@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 9, 2020

@boegel Might make sense to include these too in the 4.3.0

@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 11, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
taurusml17 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/baaf1357b3f221f2b5a317f4461e43de for a full test report.

@boegel boegel changed the title [TensorFlow 2.2.0] Use more easybuild installed dependencies use more easybuild installed dependencies for TensorFlow 2.2.0 Sep 24, 2020
boegel
boegel previously approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the next release (4.3.1) milestone Sep 25, 2020
@boegel
Copy link
Member

boegel commented Sep 25, 2020

@boegelbot please test @ generoso

@Flamefire
Remove kerase-applications dependency
329f810 
This is no longer required as it is contained in TF since 2.2:
tensorflow/tensorflow@23c3bda
@boegel
Copy link
Member

boegel commented Sep 25, 2020 •
edited
Loading

@Flamefire Your last commit reverts what I did in #11156

Even though Keras-Applications is not required for TensorFlow itself, applications on top of TensorFlow often still expect it to be there...

@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 25, 2020

Applications on top of TF should use import tf.keras.applications not import keras_applications as the latter seems to be an implementation detail so they could share this module between their repos (which they now no longer do).

I'd argue that this doesn't belong here because it is not a dependency of TF (anymore)

@boegel
Copy link
Member

boegel commented Sep 25, 2020

@Flamefire Point taken, agreed. This was done for DeepGalaxy btw.

@easybuilders easybuilders deleted a comment from boegelbot Sep 25, 2020
@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 25, 2020

Test report by @Flamefire
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in this PR)
taurusml3 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/91a8dc6b026fd5e3a721a05bc8dfcc9a for a full test report.

@boegelbot
Copy link
Collaborator

boegelbot commented Sep 25, 2020

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11224 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11224 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7961

Test results coming soon (I hope)...

Details

- notification for comment with ID 698782523 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Sep 25, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3407.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/7ff6cc31293aad52fdf5f6f0e7d11a34 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 25, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2657.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/41fa276f7fd0eea584d9771ee1de68b9 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 25, 2020

@Flamefire Trouble on POWER?

@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 25, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
taurusi5196.taurus.hrsk.tu-dresden.de - Linux RHEL 7.8, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/d4443285ae329d1909f7f1b3bb31b187 for a full test report.

@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 25, 2020 •
edited
Loading

@boegel ICU again, can be ignored. Restarting anyway

@boegelbot
Copy link
Collaborator

boegelbot commented Sep 25, 2020

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
generoso-x-2 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/bb9331fd6a7059cd5deaeec51e8a55a6 for a full test report.

@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 25, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
taurusml13 - Linux RHEL 7.6, POWER, 8335-GTX, Python 2.7.5
See https://gist.github.com/f4a2729e3839ec2e67c2d76aad25a7fb for a full test report.

@boegel boegel changed the title use more easybuild installed dependencies for TensorFlow 2.2.0 use more EasyBuild installed dependencies for TensorFlow 2.2.0 Sep 25, 2020
boegel
boegel approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Sep 25, 2020

Going in, thanks @Flamefire!

@boegel boegel merged commit 8da2dd2 into easybuilders:develop Sep 25, 2020
@Flamefire Flamefire deleted the tensorflow2.2 branch September 25, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change enhancement

Projects

None yet

Milestone

4.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @boegel @boegelbot