-
Notifications
You must be signed in to change notification settings - Fork 772
Remove GLog and GFlags from PyTorch 1.4.0 #11322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GLog and GFlags from PyTorch 1.4.0 #11322
Conversation
|
Test report by @Flamefire |
|
Test report by @Flamefire |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@boegelbot please test @ generoso |
|
The failures on Power seems to be caused by OpenMP using code and go away with reducing OMP_NUM_THREADS but I already do that... Strange, so I guess still a bit flaky even with only 4 OMP threads |
|
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 697299579 processed Message to humans: this is just bookkeeping information for me, |
|
@Flamefire failing test on POWER? |
|
Test report by @Flamefire |
|
🤷 Seems to work |
|
Test report by @boegelbot |
|
Test report by @boegel |
|
Going in, thanks @Flamefire! |
|
Test report by @lexming |
|
Test report by @boegel |
As discussed in Slack and confirmed in pytorch/pytorch#44948 using those 2 is not officially tested and known to cause problems at least on POWER architectures
Hence the removal