-
Notifications
You must be signed in to change notification settings - Fork 772
Use EasyBlock for PyTorch 1.3.1 and remove glog & gflags #11325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use EasyBlock for PyTorch 1.3.1 and remove glog & gflags #11325
Conversation
bcf3231 to
e7c4c54
Compare
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
@boegelbot please test @ generoso |
|
@Flamefire failing tests on POWER? |
|
Yes, need to add the exclusions too. Let's see what it needs -.- |
|
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 697297773 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @Flamefire |
|
Test report by @boegelbot |
|
Test report by @Flamefire |
|
@Flamefire More? |
|
Jep, kinda expected. Adding them one by one and it will likely be the same as 1.4.0 in the end. Still need to test them... |
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
Test report by @lexming |
|
Test report by @lexming |
|
@lexming No idea why the CUDA test fails, another PyTorch bug? Ignore? Retry? |
|
Test report by @lexming |
|
Test report by @lexming |
lexming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@Flamefire now it worked, the randomness of PyTorch tests is always baffling. Going in, thanks! |
As discussed in Slack and confirmed in pytorch/pytorch#44948 using those 2 is not officially tested and known to cause problems at least on POWER architectures
Hence the removal
Also updated to use the EasyBlock, promote Ninja to runtime dep and use EasyBuild installed protobuf (same as 1.4+ version ECs)