Skip to content

Remove GLog and GFlags from PyTorch 1.2.0 #11327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 1 commit into from
Sep 23, 2020
Merged

Remove GLog and GFlags from PyTorch 1.2.0 #11327

boegel merged 1 commit into from
Sep 23, 2020

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Sep 22, 2020

As discussed in Slack and confirmed in pytorch/pytorch#44948 using those 2 is not officially tested and known to cause problems at least on POWER architectures

Hence the removal

@Flamefire
Copy link
Contributor Author

Flamefire commented Sep 22, 2020

Test report by @Flamefire
SUCCESS
Build succeeded for 7 out of 7 (2 easyconfigs in this PR)
taurusi5532.taurus.hrsk.tu-dresden.de - Linux RHEL 7.8, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/f069b9476f56d9c6e8570212de27fd89 for a full test report.

boegel
boegel approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the bug fix label Sep 23, 2020
@boegel boegel added this to the next release (4.3.1) milestone Sep 23, 2020
@boegel
Copy link
Member

boegel commented Sep 23, 2020

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2563.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/3e205c537aed3d04556be638692862ff for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Sep 23, 2020
@boegel
Copy link
Member

boegel commented Sep 23, 2020

Going in, thanks @Flamefire!

@boegel boegel merged commit 64e593b into easybuilders:develop Sep 23, 2020
@Flamefire Flamefire deleted the pytorch1.2-remove-glog-gflags branch September 23, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.1

Development

Successfully merging this pull request may close these issues.

2 participants

@Flamefire @boegel