update Java/1.8 wrapper to also support aarch64 #11545

terjekv · 2020-10-20T11:20:44Z

(created using eb --new-pr)

The versionsuffix changes to the power version is to support --try-update-deps as 91-b26-OpenJDK isn't a testable version.

…version is to support --try-update-deps as '91-b26-OpenJDK' isn't a testable version.

boegel · 2020-10-20T13:23:29Z

easybuild/easyconfigs/j/Java/Java-1.8-aarch64.eb

+
+toolchain = SYSTEM
+
+source_urls = ['https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u265-b01/']


The 8u265-b01 part should be reflected via versionsuffix?

So you want the versionsuffix to be -aarch64-8u265-b01 (or -8u265-b01-aarch64)?

I would say the version string should minimum include

version = '1.8_265'

and the remaining, aarch64, OpenJDK, and build(?) number should be part of the either the version or versionsuffix. So maybe

version = '1.8_265-b01-OpenJDK' versionsuffix = '-aarch64'

or

version = '1.8_265' versionsuffix = '-b01-OpenJDK-aarch64'

Micket · 2020-10-21T09:55:23Z

easybuild/easyconfigs/j/Java/Java-1.8-aarch64.eb

+
+toolchain = SYSTEM
+
+source_urls = ['https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u265-b01/']


I would say the version string should minimum include

version = '1.8_265'

and the remaining, aarch64, OpenJDK, and build(?) number should be part of the either the version or versionsuffix. So maybe

version = '1.8_265-b01-OpenJDK' versionsuffix = '-aarch64'

or

version = '1.8_265' versionsuffix = '-b01-OpenJDK-aarch64'

easybuild/easyconfigs/j/Java/Java-1.8.eb

terjekv · 2020-10-21T10:03:15Z

Can do, but please also note easybuilders/easybuild-framework#3475 (comment). Versionsuffix that can't be fed to LooseVersion() breaks --try-update-deps.

easybuild/easyconfigs/j/Java/Java-1.8-8u265-b01-aarch64.eb

boegel · 2020-10-27T08:25:16Z

@terjekv @branfosj test reports from aarch64 and ppcle64?

boegel · 2020-10-27T08:25:22Z

@boegelbot please test @ generoso

boegelbot · 2020-10-27T08:30:09Z

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11545 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11545 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 8203

Test results coming soon (I hope)...

Details

- notification for comment with ID 717073185 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

terjekv · 2020-10-27T08:52:00Z

Test report by @terjekv
FAILED
Build succeeded for 0 out of 1 (3 easyconfigs in total)
arm2 - Linux ubuntu 18.04, AArch64, UNKNOWN, Python 3.6.9
See https://gist.github.com/68f26faf9e6bb26347090204183e1ab5 for a full test report.

branfosj · 2020-10-27T09:00:47Z

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0305u11a.bear.cluster - Linux RHEL 7.6, POWER, 8335-GTX (power9le), Python 3.6.8
See https://gist.github.com/381351eb6cc064a7721899a862ef5b05 for a full test report.

terjekv · 2020-10-27T09:04:31Z

Test report by @terjekv
FAILED
Build succeeded for 0 out of 1 (3 easyconfigs in total)
arm2 - Linux ubuntu 18.04, AArch64, UNKNOWN, Python 3.6.9
See https://gist.github.com/68f26faf9e6bb26347090204183e1ab5 for a full test report.

It's trying to install the Power version? Why?

Micket · 2020-10-27T09:05:59Z

Because you also modified that easyconfig. --from-pr will pick up everything that you changed (you can specify which easyconfigs in the same command line to limit it)

terjekv · 2020-10-27T09:08:17Z

Test report by @terjekv
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
arm2 - Linux ubuntu 18.04, AArch64, UNKNOWN, Python 3.6.9
See https://gist.github.com/cfd7afa31761be8e37537db7307599f6 for a full test report.

terjekv · 2020-10-27T09:08:33Z

Because you also modified that easyconfig. --from-pr will pick up everything that you changed (you can specify which easyconfigs in the same command line to limit it)

Aha! Thanks!

boegel · 2020-10-27T19:21:22Z

@boegelbot please test @ generoso
EB_ARGS="Java-1.8.eb"

boegel · 2020-10-27T19:23:36Z

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2619.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/8ae2ce662f0a47819fc99ea7dc837f36 for a full test report.

boegelbot · 2020-10-27T19:25:09Z

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11545 EB_ARGS="Java-1.8.eb" /apps/slurm/default/bin/sbatch --job-name test_PR_11545 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 8205

Test results coming soon (I hope)...

Details

- notification for comment with ID 717479886 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2020-10-27T19:25:24Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/84fad6a50d4df3c816eeefb764231a9e for a full test report.

boegel

lgtm

aarch64-support for Java 1.8. The versionsuffix changes to the power …

cc30d10

…version is to support --try-update-deps as '91-b26-OpenJDK' isn't a testable version.

terjekv added the update label Oct 20, 2020

terjekv changed the title ~~aarch64-support for Java 1.8. The versionsuffix changes to the power version is to support --try-update-deps as '91-b26-OpenJDK' isn't a testable version.~~ aarch64-support for Java 1.8. Oct 20, 2020

terjekv added the aarch64 Related to Arm 64-bit (aarch64) label Oct 20, 2020

Appease the hound.

30eec8a

boegel requested changes Oct 20, 2020

View reviewed changes

boegel added this to the next release (4.3.1) milestone Oct 20, 2020

This comment has been minimized.

Sign in to view

Micket reviewed Oct 21, 2020

View reviewed changes

terjekv mentioned this pull request Oct 21, 2020

--try-update-deps and Java. easybuilders/easybuild-framework#3475

Open

Fix version suffix of Java 1.8 for aarch64.

31ab26b

boegel changed the title ~~aarch64-support for Java 1.8.~~ update Java/1.8 wrapper to also support aarch64 Oct 25, 2020

boegel requested changes Oct 25, 2020

View reviewed changes

easybuild/easyconfigs/j/Java/Java-1.8-8u265-b01-aarch64.eb Outdated Show resolved Hide resolved

boegel modified the milestones: 4.3.1 (next release), 4.3.2 Oct 25, 2020

boegel added change enhancement and removed update labels Oct 25, 2020

terjekv added 3 commits October 26, 2020 10:19

Fix version data.

44f8af7

Remove comments, appease Hound.

64a05d9

Style fix.

14085a9

terjekv requested review from Micket and boegel October 26, 2020 11:45

easybuilders deleted a comment from boegelbot Oct 27, 2020

boegel modified the milestones: 4.3.2, 4.3.1 (next release) Oct 27, 2020

easybuilders deleted a comment from boegelbot Oct 27, 2020

boegel approved these changes Oct 27, 2020

View reviewed changes

boegel merged commit ea40e27 into easybuilders:develop Oct 27, 2020


		toolchain = SYSTEM

		source_urls = ['https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u265-b01/']

update Java/1.8 wrapper to also support aarch64 #11545

update Java/1.8 wrapper to also support aarch64 #11545

Uh oh!

Conversation

terjekv commented Oct 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boegel Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

terjekv Oct 20, 2020

Choose a reason for hiding this comment

Uh oh!

Micket Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

Micket Oct 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

terjekv commented Oct 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

boegel commented Oct 27, 2020

Uh oh!

boegel commented Oct 27, 2020

Uh oh!

boegelbot commented Oct 27, 2020

Uh oh!

terjekv commented Oct 27, 2020

Uh oh!

branfosj commented Oct 27, 2020

Uh oh!

terjekv commented Oct 27, 2020

Uh oh!

Micket commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

terjekv commented Oct 27, 2020

Uh oh!

terjekv commented Oct 27, 2020

Uh oh!

boegel commented Oct 27, 2020

Uh oh!

boegel commented Oct 27, 2020

Uh oh!

boegelbot commented Oct 27, 2020

Uh oh!

boegelbot commented Oct 27, 2020

Uh oh!

boegel left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

terjekv commented Oct 20, 2020 •

edited

Loading

terjekv commented Oct 21, 2020 •

edited

Loading

Micket commented Oct 27, 2020 •

edited

Loading