Skip to content

Conversation

@nordmoen
Copy link
Contributor

Added new multi-arch version of NVHPC, this requires easyblock PR
easybuilders/easybuild-easyblocks#2233.

Added new multi-arch version of NVHPC, this requires `easyblock` PR
easybuilders/easybuild-easyblocks#2233.
@boegelbot

This comment has been minimized.

@Micket Micket added the update label Nov 12, 2020
@Micket Micket added this to the 4.x milestone Nov 12, 2020
@boegelbot

This comment has been minimized.

@Micket
Copy link
Contributor

Micket commented Nov 24, 2020

So, this looks very much like, the previous version, but, I have some concerns;

dependencies = [
    ('GCCcore', local_gccver),
    ('binutils', '2.34', '', ('GCCcore', local_gccver)),
    # This is necessary to avoid cases where just libnuma.so.1 is present in the system and -lnuma fails
    ('numactl', '2.0.13', '', ('GCCcore', local_gccver))
]

Rather than all this, why not put it under GCCcore and depend on these modules normally? You'd end up with this anyway. I'm also not sure

    ('numactl', '2.0.13', '', ('GCCcore', local_gccver))

works at all on HMNS, so seeing this is a big code-smell to me.

Also, why not actually depend on the CUDAcore are are using for the toolchain anyway?

@akesandgren
Copy link
Contributor

@Micket This is a a compiler toolchain and as such can't be under another toolchain.
Look at how the iccifort definitions look, this is the same thing.

@boegel
Copy link
Member

boegel commented Dec 31, 2020

@boegelbot please test @ generoso
EB_ARGS="--cuda-compute-capabilities=7.0"

@boegel
Copy link
Member

boegel commented Dec 31, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3154.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/461c328407eb39279c1fc5612495cf51 for a full test report.

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11694 EB_ARGS="--cuda-compute-capabilities=7.0" /apps/slurm/default/bin/sbatch --job-name test_PR_11694 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12352

Test results coming soon (I hope)...

Details

- notification for comment with ID 752964593 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/72834322b69dd3334668b77b44e1412d for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel modified the milestones: 4.x, next release (4.3.3?) Dec 31, 2020
@boegel
Copy link
Member

boegel commented Dec 31, 2020

Going in, thanks @nordmoen!

@boegel boegel merged commit 15dc049 into easybuilders:develop Dec 31, 2020
@boegel boegel changed the title {compiler} [NVHPC/20.9] Added new multi arch version {compiler}[SYSTEM] NVHPC v20.9 Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants