-
Notifications
You must be signed in to change notification settings - Fork 772
in-place update to magma 2.5.4 for PyTorch easyconfigs using fosscuda/2019b toolchain #11726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in-place update to magma 2.5.4 for PyTorch easyconfigs using fosscuda/2019b toolchain #11726
Conversation
|
The failing tests that complain about introducing two Also, please motivate this change, since we usually don't do in-place updates of dependencies, unless there's a very good reason for it. edit: motivation mentioned in #11656 |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, test report coming up...
|
Test report by @Flamefire |
|
Test report by @boegel |
|
@Flamefire Any idea what went wrong with your test report? |
|
Yes: I started it before the CUDA 11 patch was added. The failure will be fixed by the patch as shown by the other tests. Shall I rerun the tests? |
If it's no too much trouble, yes please. |
|
Test report by @Flamefire |
|
Going in, thanks @Flamefire! |
(created using
eb --new-pr)Fixes a known Bug, see #11656