Skip to content

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Nov 16, 2020

(created using eb --new-pr)

Fixes a known Bug, see #11656

@boegel
Copy link
Member

boegel commented Nov 16, 2020

The failing tests that complain about introducing two magma versions in the 2019b generation are going to make this difficult to merge, so please merge this PR with #11725 and #11724 . It'll be a bit painful to submit test reports for, but so be it...

Also, please motivate this change, since we usually don't do in-place updates of dependencies, unless there's a very good reason for it.

edit: motivation mentioned in #11656

@boegel boegel changed the title [PyTorch 1.6.0] Update magma to 2.5.4 in-place update to magma 2.5.4 for PyTorch easyconfigs using fosscuda/2019b toolchain Nov 16, 2020
@easybuilders easybuilders deleted a comment from boegelbot Nov 16, 2020
boegel
boegel previously approved these changes Nov 16, 2020
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, test report coming up...

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in total)
taurusa6 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz, Python 2.7.5
See https://gist.github.com/e12b0ec1d17198e0eb6b476c13c9d915 for a full test report.

@boegel
Copy link
Member

boegel commented Nov 17, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3307.joltik.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/c46303adcf2e069750f1c90f41b9ab3d for a full test report.

@boegel
Copy link
Member

boegel commented Nov 17, 2020

@Flamefire Any idea what went wrong with your test report?

@Flamefire
Copy link
Contributor Author

Yes: I started it before the CUDA 11 patch was added. The failure will be fixed by the patch as shown by the other tests. Shall I rerun the tests?

@boegel
Copy link
Member

boegel commented Nov 17, 2020

Yes: I started it before the CUDA 11 patch was added. The failure will be fixed by the patch as shown by the other tests. Shall I rerun the tests?

If it's no too much trouble, yes please.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
taurusa5 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz, Python 2.7.5
See https://gist.github.com/fdafa1afad6f548d82b4207549a2844a for a full test report.

@boegel
Copy link
Member

boegel commented Nov 23, 2020

Going in, thanks @Flamefire!

@boegel boegel merged commit 039bd2a into easybuilders:develop Nov 23, 2020
@Flamefire Flamefire deleted the 20201116092520_new_pr_PyTorch160 branch November 27, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants