{cae}[foss/2020a] OpenFOAM v2012 #11876

olesenm · 2020-12-14T09:52:07Z

Hi @boegel - a heads-up for the upcoming OpenFOAM-v2012

To help accommodate easybuild and other systems, we have an additional FOAM_CONFIG_ETC variable that we can hook into to quickly switch between different types of configurations (eg, intelmpi/openmpi, 64/32-bit, spdp/dp etc). It also can be used by easybuild to define its configuration, largely without patching the original sources.

The OpenFOAM internal mpi selector now recognizes "EASYBUILDMPI" (no patching needed), and the readline discovery can be customized with the usual config.sh mechanism, which means that easybuild can generate its settings without patching into the wmake/scripts directory. Using this approach, we are getting one step closer to being able to generate settings on-the-fly instead of patching.

In this preliminary changeset, I did however run into issues with actually applying the patch for the build. EasyBuild complains about not being able to determine the patch level. Must be something small I guess, but figured I should provide the changeset anyhow to provide a basis and avoid duplicate effort.

boegel · 2020-12-14T10:49:55Z

@olesenm Thanks a lot!

EasyBuild has some magic to automatically determine the patch level to use, which is derived from the first +++ line in the patch. Shouldn't be difficult to fix, indeed. Worst case we can hard specify the correct patch level (patches = [('example.patch', 1)], where 1 results in running patch -p1).

Any ETA for the OpenFOAM v2012 release?

olesenm · 2020-12-14T11:04:29Z

Any ETA for the OpenFOAM v2012 release?

Likely by Monday/Tuesday next week.

olesenm · 2020-12-14T11:33:20Z

BTW: In case it is useful, the code-wiki is unfortunately a bit hard to find
https://develop.openfoam.com/Development/openfoam/-/wikis/home

If there is anything better that you would liked added in here:
https://develop.openfoam.com/Development/openfoam/-/wikis/building#packaging-systems

olesenm · 2020-12-21T23:04:39Z

@boegel - on the final stretch...

olesenm · 2020-12-23T13:55:16Z

https://sourceforge.net/projects/openfoam/files/v2012/

boegel · 2020-12-27T16:57:04Z

@olesenm I tested this, and although the installation completes after ~1.5h, EasyBuild isn't entirely happy with it; the sanity check fails because the following files are missing in the installation:

OpenFOAM-v2012/platforms/linux64GccDPInt32Opt/lib/mpi/libPstream.so
OpenFOAM-v2012/platforms/linux64GccDPInt32Opt/lib/mpi/libptscotchDecomp.so
OpenFOAM-v2012/platforms/linux64GccDPInt32Opt/lib/libscotchDecomp.so

For libPstream.so, I found lib/eb-mpi/libPstream.so instead (eb-mpi rather than mpi).

For the other two, I couldn't find an equivalent, and I couldn't spot any obvious errors in the installation either.

Have there been changes in the v2012 that we should be aware of?

olesenm · 2020-12-29T16:15:59Z

OpenFOAM-v2012/platforms/linux64GccDPInt32Opt/lib/mpi/libPstream.so
OpenFOAM-v2012/platforms/linux64GccDPInt32Opt/lib/mpi/libptscotchDecomp.so
OpenFOAM-v2012/platforms/linux64GccDPInt32Opt/lib/libscotchDecomp.so
For libPstream.so, I found lib/eb-mpi/libPstream.so instead (eb-mpi rather than mpi).

For the other two, I couldn't find an equivalent, and I couldn't spot any obvious errors in the installation either.

Have there been changes in the v2012 that we should be aware of?

This is either a feature or an oops. The mpi handling was adjusted to avoid potential conflicts. The tag "mpi" was adjusted to "sys-mpi" (since that it is), similarly "openmpi-system" became "sys-openmpi" etc. (gives lib/sys-mpi, lib/sys-openmpi, lib/sys-openmpi4 etc).
As part of the mpi adjustments, inserted handling of Easybuild with "eb-mpi" as its backend (yields lib/eb-mpi). Missed out on the fact that these would be trapped by a sanity check somewhere. Apologies for that.

Here are some relevant commits
https://develop.openfoam.com/Development/openfoam/-/commit/c91fc6f41cc4d4f1ac782d4f7fd8c35ca4e5bea8

https://develop.openfoam.com/Development/openfoam/-/commit/b89f38960651701ed76a87e21c7a566fe0714f3c

.. again apologies for breaking the sanity check

olesenm · 2020-12-29T16:20:18Z

Might need to check if the scotch detection is working as expected/desired.
After Easybuild has generated its config.sh/ files for OpenFOAM, can check using

sh wmake/scripts/have_scotch -test

furstj · 2021-01-27T11:32:50Z

@olesenm Your proposed new layout requires patched openfaom easyblock. You can try it with easyblock from easybuilders/easybuild-easyblocks#2321.

Moreover, the correct patch level in openfoam easyconfig file should be 1, i.e.

patches = [ ('OpenFOAM-%(version)s-cleanup.patch', 1), 'OpenFOAM-v1906-wmake-ompi.patch', ]

boegel · 2021-02-04T11:17:47Z

@furstj Did you manage to install OpenFOAM v2012 with this PR and the updated easyblock from easybuilders/easybuild-easyblocks#2321? Did you have to change anything other than the patches part?

furstj · 2021-02-04T12:25:29Z

@boegel Yes, I was able to install OpenFOAMv2012 with updated easyblock when I changed patches part.

easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2012-foss-2020a.eb

Co-authored-by: Mikael Öhman <[email protected]>

boegel · 2021-02-04T19:47:11Z

@boegelbot please test @ generoso
CORE_CNT=16

boegelbot · 2021-02-04T19:50:43Z

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11876 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11876 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 13782

Test results coming soon (I hope)...

Details

- notification for comment with ID 773560947 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2021-02-04T21:20:16Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/9dbd1ec6038ac8c342e92762edd84ebc for a full test report.

patch level fixed

boegel

lgtm

boegel · 2021-02-05T14:31:01Z

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3624.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/2310e4c6f0ae93ac268cbdc4c9692caf for a full test report.

boegel · 2021-02-05T14:43:02Z

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2613.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/d99af81344eeb68429606d1f71843ce8 for a full test report.

boegel · 2021-02-14T10:58:39Z

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3142.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/8e4fe4ef37fc4b86abadd458425401ed for a full test report.

boegel · 2021-02-14T19:06:15Z

Going in, thanks @olesenm!

Micket · 2021-02-18T16:54:11Z

Test report by @Micket
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2321
SUCCESS
Build succeeded for 8 out of 8 (1 easyconfigs in total)
vera-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 2.7.5
See https://gist.github.com/4e15f6d0f92faa36206c596d9b5eaef9 for a full test report.

WIP: preliminary layout for OpenFOAM-v2012

f34c270

boegel added this to the next release (4.3.3?) milestone Dec 14, 2020

boegel added the update label Dec 14, 2020

boegel added 2 commits December 27, 2020 10:29

fix source URL + checksum for OpenFOAM v2012

509d391

specify patch level for OpenFOAM v2012 cleanup patch

d717875

Micket previously requested changes Feb 4, 2021

View reviewed changes

easybuild/easyconfigs/o/OpenFOAM/OpenFOAM-v2012-foss-2020a.eb Outdated Show resolved Hide resolved

fix patch level for OpenFOAM-v2012-cleanup.patch

04223d1

Co-authored-by: Mikael Öhman <[email protected]>

boegel changed the title ~~WIP: preliminary layout for OpenFOAM-v2012~~ {cae}[foss/2020a] OpenFOAM v2012 Feb 5, 2021

boegel approved these changes Feb 5, 2021

View reviewed changes

easybuilders deleted a comment from boegelbot Feb 13, 2021

boegel merged commit 59324fa into easybuilders:develop Feb 14, 2021

olesenm deleted the openfoam-pre2012 branch February 15, 2021 17:16

{cae}[foss/2020a] OpenFOAM v2012 #11876

{cae}[foss/2020a] OpenFOAM v2012 #11876

Uh oh!

Conversation

olesenm commented Dec 14, 2020

Uh oh!

boegel commented Dec 14, 2020

Uh oh!

olesenm commented Dec 14, 2020

Uh oh!

olesenm commented Dec 14, 2020

Uh oh!

olesenm commented Dec 21, 2020

Uh oh!

olesenm commented Dec 23, 2020

Uh oh!

boegel commented Dec 27, 2020

Uh oh!

olesenm commented Dec 29, 2020

Uh oh!

olesenm commented Dec 29, 2020

Uh oh!

furstj commented Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boegel commented Feb 4, 2021

Uh oh!

furstj commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

boegel commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boegelbot commented Feb 4, 2021

Uh oh!

boegelbot commented Feb 4, 2021

Uh oh!

boegel left a comment

Choose a reason for hiding this comment

Uh oh!

boegel commented Feb 5, 2021

Uh oh!

boegel commented Feb 5, 2021

Uh oh!

boegel commented Feb 14, 2021

Uh oh!

boegel commented Feb 14, 2021

Uh oh!

Micket commented Feb 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

furstj commented Jan 27, 2021 •

edited

Loading

furstj commented Feb 4, 2021 •

edited

Loading

boegel commented Feb 4, 2021 •

edited

Loading