-
Notifications
You must be signed in to change notification settings - Fork 772
Remove duplicate extensions in R 3.5.x easyconfigs, and add test to detect such issues #12059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate extensions in R 3.5.x easyconfigs, and add test to detect such issues #12059
Conversation
f5ac4d2 to
aa1aff2
Compare
|
It seems that promises-1.0.1 is also duplicated in the easyconfig. In this case it is not causing the build to fail though. |
|
Yeah, there were in fact 3 duplicate packages but only 1 with different versions which caused the problem |
|
Test report by @lexming |
|
@Flamefire you opened Pandora's box here
|
8b1f9cf to
8599893
Compare
8599893 to
5555c7b
Compare
|
I hate R/CRAN! |
|
Test report by @lexming |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I also have a test report coming up, but it'll need a couple hours more... Should show up today. |
lexming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@boegel too slow 🐢 Going in, thanks @Flamefire ! |
|
Test report by @boegel |
|
@boegel Yours shows an unrelated issue but might be worth fixing:
In an iomkl build! |
|
What the... Please open an issue on that. |
A user reported a failure when building with:
eb --package R-3.5.1-foss-2018b.eb --skip --force --ignore-checksum --debug --infoReason seems to be duplicated packages in the R ECs.
Removed the older versions and added a test case to detect this