-
Notifications
You must be signed in to change notification settings - Fork 772
Add tensorboard profile plugin to TensorFlow 2.3.1 #12137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tensorboard profile plugin to TensorFlow 2.3.1 #12137
Conversation
|
Test report by @Micket |
|
Hm, these seem to be unrelated issues regarding google.protobuf. Perhaps I need to rebuild some stuff (but I don't want to touch this system unnecessarily). So, I would ignore the 2 failures here for the sake of this PR. Test report by @Micket |
|
Test report by @branfosj |
|
Test report by @branfosj |
|
@boegelbot please test @ generoso |
branfosj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, these seem to be unrelated issues regarding google.protobuf. Perhaps I need to rebuild some stuff (but I don't want to touch this system unnecessarily). So, I would ignore the 2 failures here for the sake of this PR.
Yes, I agree that the failures in the test report look unrelated to the changes here. My test report were fine and the ones from generosa should be along at some point.
|
@branfosj: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 778089001 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Going in, thanks @Micket! |
(created using
eb --new-pr)