Skip to content

remove PYPI_SOURCE source URL from easyconfigs using 2020b toolchain #12451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
verdurin merged 2 commits into from
Mar 24, 2021
Merged

remove PYPI_SOURCE source URL from easyconfigs using 2020b toolchain #12451

verdurin merged 2 commits into from
Mar 24, 2021

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Mar 23, 2021 •
edited
Loading

This is no longer required as it became the default with easybuilders/easybuild-easyblocks#2364

Tests should (and mine were) be done with e.g. eb --from-pr 12451 --rebuild --fetch --force-download --sourcepath=/dev/shm/sources --upload-test-report to only test the download and of course with latest develop easyblocks

@Flamefire Flamefire force-pushed the removePYPIsrc_2020x branch from 8b90682 to 0d40fcf Compare March 23, 2021 08:53
@Flamefire
Remove source_urls = [PYPI_SOURCE] from 2020b ECs
ec147a9 
This is no longer required as it became the default with easybuilders/easybuild-easyblocks#2364
@Flamefire Flamefire force-pushed the removePYPIsrc_2020x branch from 5b3572f to ec147a9 Compare March 23, 2021 10:16
@Flamefire Flamefire changed the title Remove source_urls = [PYPI_SOURCE] from 2020a/b ECs Remove source_urls = [PYPI_SOURCE] from 2020b ECs Mar 23, 2021
@Flamefire
Copy link
Contributor Author

Flamefire commented Mar 23, 2021

Test report by @Flamefire
FAILED
Build succeeded for 78 out of 79 (79 easyconfigs in total)
taurusa4 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/20c90bcd1387097546cd39fea2e9480f for a full test report.

@Flamefire
Copy link
Contributor Author

Flamefire commented Mar 23, 2021

Test report by @Flamefire
SUCCESS
Build succeeded for 79 out of 79 (79 easyconfigs in total)
taurusa4 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/639b329cca9ce306d4ae3059829785cc for a full test report.

@Flamefire Flamefire mentioned this pull request Mar 23, 2021
Merged
verdurin
verdurin requested changes Mar 23, 2021
View reviewed changes
@boegel boegel added this to the next release (4.3.4?) milestone Mar 23, 2021
@Flamefire Flamefire requested a review from verdurin March 24, 2021 07:34
@boegel boegel changed the title Remove source_urls = [PYPI_SOURCE] from 2020b ECs remove PYPI_SOURCE source URL from easyconfigs using 2020b toolchain Mar 24, 2021
@verdurin
Copy link
Member

verdurin commented Mar 24, 2021

Test report by @verdurin
FAILED
Build succeeded for 284 out of 288 (79 easyconfigs in total)
easybuild-c7.novalocal - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/388befc469a8ff9379c4d162d8f52c6e for a full test report.

verdurin
verdurin approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

verdurin commented Mar 24, 2021

Going in, thanks @Flamefire!

@verdurin verdurin merged commit cdaf774 into easybuilders:develop Mar 24, 2021
@Flamefire Flamefire deleted the removePYPIsrc_2020x branch March 24, 2021 16:52
@boegel
Copy link
Member

boegel commented Mar 24, 2021

Test report by @boegel
SUCCESS
Build succeeded for 81 out of 81 (79 easyconfigs in total)
node3301.joltik.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz (cascadelake), Python 3.6.8
See https://gist.github.com/ebc4c845ffe84b78c0f9e816b366109f for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel left review comments

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

change code cleanup

Projects

None yet

Milestone

4.3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @verdurin @boegel