Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Apr 20, 2021

Issues fixed:

@easybuilders easybuilders deleted a comment from boegelbot Apr 21, 2021
@boegel boegel added the change label Apr 21, 2021
@boegel
Copy link
Member Author

boegel commented Apr 21, 2021

Once the tests pass, I should probably pull out the Hadoop change into its own PR, to highlight the change (so it'll be listed in the release notes)...

edit: see #12709

@boegel
Copy link
Member Author

boegel commented Apr 22, 2021

I need to verify that this indeed picks up on different dependency variants across (sub)toolchains in the same generation, so don't merge this just yet...

@boegel boegel modified the milestones: release after 4.9.4, release after 5.0.0 Mar 18, 2025
@Flamefire
Copy link
Contributor

Just remembered this old PR as we recently had the case that there is a Java 17 and Java 21 in our toolchain as some easyconfigs were GCC(core) and others foss so the conflict was missed.
Just as a motivation to finish this ;-)

@akesandgren
Copy link
Contributor

Yeah, ping @boegel

@github-actions github-actions bot removed the change label Jun 16, 2025
from easybuild.framework.easyconfig.tools import check_sha256_checksums, dep_graph, get_paths_for, process_easyconfig
from easybuild.tools import config, LooseVersion
from easybuild.tools.build_log import EasyBuildError
from easybuild.tools.build_log import EasyBuildError, print_warning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from easybuild.tools.build_log import EasyBuildError, print_warning
from easybuild.tools.build_log import EasyBuildError

…tion to only cover 2025a generation & newer, for now
@boegel boegel changed the title improve check for multi-variant dependencies per generation of easyconfigs improve check for multi-variant dependencies per generation of easyconfigs (for now, only for 2025a & newer) Jun 18, 2025
@boegel
Copy link
Member Author

boegel commented Jun 18, 2025

@branfosj Let's throw that info in dedicated issues (per toolchain generation), so we can follow up?

@branfosj
Copy link
Member

@branfosj Let's throw that info in dedicated issues (per toolchain generation), so we can follow up?

I've moved the comment into #23133 and #23134

@boegel boegel force-pushed the check_dep_vars_recent_gcccore branch from 0a1c5e8 to 3cfa544 Compare June 18, 2025 14:03
@jfgrimm
Copy link
Member

jfgrimm commented Jun 18, 2025

Going in, thanks @boegel!

@jfgrimm jfgrimm merged commit 43f8fb0 into easybuilders:develop Jun 18, 2025
8 checks passed
@boegel boegel deleted the check_dep_vars_recent_gcccore branch June 18, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make check for dependency versions per toolchain generation aware of subtoolchains

7 participants