-
Notifications
You must be signed in to change notification settings - Fork 772
improve check for multi-variant dependencies per generation of easyconfigs (for now, only for 2025a & newer) #12687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve check for multi-variant dependencies per generation of easyconfigs (for now, only for 2025a & newer) #12687
Conversation
…olchain, since it depends on Java 1.8
|
Once the tests pass, I should probably pull out the edit: see #12709 |
|
I need to verify that this indeed picks up on different dependency variants across (sub)toolchains in the same generation, so don't merge this just yet... |
|
Just remembered this old PR as we recently had the case that there is a Java 17 and Java 21 in our toolchain as some easyconfigs were GCC(core) and others foss so the conflict was missed. |
|
Yeah, ping @boegel |
test/easyconfigs/easyconfigs.py
Outdated
| from easybuild.framework.easyconfig.tools import check_sha256_checksums, dep_graph, get_paths_for, process_easyconfig | ||
| from easybuild.tools import config, LooseVersion | ||
| from easybuild.tools.build_log import EasyBuildError | ||
| from easybuild.tools.build_log import EasyBuildError, print_warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| from easybuild.tools.build_log import EasyBuildError, print_warning | |
| from easybuild.tools.build_log import EasyBuildError |
…tion to only cover 2025a generation & newer, for now
|
@branfosj Let's throw that info in dedicated issues (per toolchain generation), so we can follow up? |
e041877 to
0a1c5e8
Compare
0a1c5e8 to
3cfa544
Compare
|
Going in, thanks @boegel! |
Issues fixed:
GCCtoolchain;GCCcore-10.*toolchain;