Skip to content

Remove duplicated PYTHONPATH module entries #13385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Flamefire wants to merge 8 commits into from
Closed

Remove duplicated PYTHONPATH module entries #13385

Flamefire wants to merge 8 commits into from

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jul 8, 2021 •
edited
Loading

Those ECs set the PYTHONPATH again which is already done by the used easyblock leading to a slower module/python

Running into #13432 while testing this, hence fixed here

Fixes #13432

@Flamefire
Copy link
Contributor Author

Flamefire commented Jul 15, 2021 •
edited
Loading

Test report by @Flamefire
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in total)
taurusi6606.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/2d840b4654b1b42b376970cfcd5f8654 for a full test report.

Note: Tested all I could, excluded intel-2017 ECs from the test due to license issues

@Flamefire
Copy link
Contributor Author

Flamefire commented Jul 26, 2022

@boegel Anything required here?

@Flamefire Flamefire force-pushed the duplicate_python_path branch 6 times, most recently from adaf482 to c126ebe Compare February 6, 2023 11:42
@Flamefire
Copy link
Contributor Author

Flamefire commented Feb 7, 2023

Test report by @Flamefire
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
taurusi6403.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/707a7b7b242d937161c72c27abe8d055 for a full test report.

@boegel boegel added the bug fix label Feb 15, 2023
@easybuilders easybuilders deleted a comment from boegelbot Feb 15, 2023
@easybuilders easybuilders deleted a comment from boegelbot Feb 15, 2023
@boegel boegel added this to the next release (4.7.1?) milestone Feb 15, 2023
@boegel boegel modified the milestones: 4.8.0, release after 4.8.0 Jul 6, 2023
@Flamefire Flamefire force-pushed the duplicate_python_path branch from c126ebe to 9ea766a Compare July 24, 2023 09:00
@Flamefire
Copy link
Contributor Author

Flamefire commented Jul 24, 2023

Updated/rebased again and verified with grep -E ": 'lib/python[^/]+/site-packages'" $(grep --files-with-matches -Er "\\beasyblock = '(ConfigureMakePythonPackage|PythonBundle)'") that all are updated

@boegel boegel modified the milestones: 4.8.1, release after 4.8.1 Sep 9, 2023
@boegel
Copy link
Member

boegel commented Oct 23, 2023

@Flamefire All these easyconfigs have already been archived in the 5.0.x branch because they're using deprecated or unsupported toolchains, see also https://docs.easybuild.io/policies/toolchains, so I'm not sure it's worth pursuing this (sorry).

Can we enhance the easyconfigs test suite so these duplicated PYTHONPATH entries can be avoided going forward?

@Flamefire Flamefire mentioned this pull request Oct 23, 2023
Open
1 task
@Flamefire
Copy link
Contributor Author

Flamefire commented Oct 23, 2023

@Flamefire All these easyconfigs have already been archived in the 5.0.x branch because they're using deprecated or unsupported toolchains, see also https://docs.easybuild.io/policies/toolchains, so I'm not sure it's worth pursuing this (sorry).

Hm, ok

Can we enhance the easyconfigs test suite so these duplicated PYTHONPATH entries can be avoided going forward?

Maybe: #19061

@boegel boegel removed this from the next release (4.9.0) milestone Dec 29, 2023
@boegel boegel added this to the release after 4.9.0 milestone Dec 29, 2023
@Flamefire
Copy link
Contributor Author

Flamefire commented Feb 23, 2024

Can this be merged? Fixed conflicts again

@boegel boegel modified the milestones: 4.9.1, release after 4.9.1 Apr 3, 2024
Flamefire added a commit to Flamefire/easybuild-easyconfigs that referenced this pull request Apr 16, 2024
@Flamefire
Add test for duplicate PYTHONPATH in modextrapaths
97c2a61 
And similar test for `sanity_check_paths`.

Intended to avoid issues fixed in easybuilders#13385
@boegel boegel modified the milestones: 4.9.2, release after 4.9.2 Jun 8, 2024
@Flamefire Flamefire force-pushed the duplicate_python_path branch from 434cd10 to 602e0bd Compare July 4, 2024 11:33
@Flamefire Flamefire mentioned this pull request Jul 4, 2024
Merged
1 task
@boegel boegel modified the milestones: 4.9.3, release after 4.9.3 Sep 11, 2024
@Flamefire
Copy link
Contributor Author

Flamefire commented Dec 19, 2024

Closing for #20960

@Flamefire Flamefire closed this Dec 19, 2024
Flamefire added a commit to Flamefire/easybuild-easyconfigs that referenced this pull request Dec 19, 2024
@Flamefire
Add test for duplicate PYTHONPATH in modextrapaths
6a8a343 
And similar test for `sanity_check_paths`.

Intended to avoid issues fixed in easybuilders#13385
Flamefire added a commit to Flamefire/easybuild-easyconfigs that referenced this pull request Feb 5, 2025
@Flamefire
Add test for duplicate PYTHONPATH in modextrapaths
01547d1 
And similar test for `sanity_check_paths`.

Intended to avoid issues fixed in easybuilders#13385
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Flamefire added a commit to Flamefire/easybuild-easyconfigs that referenced this pull request May 8, 2025
@Flamefire
Add test for duplicate PYTHONPATH in modextrapaths
30cf427 
And similar test for `sanity_check_paths`.

Intended to avoid issues fixed in easybuilders#13385
Flamefire added a commit to Flamefire/easybuild-easyconfigs that referenced this pull request May 8, 2025
@Flamefire
Add test for duplicate PYTHONPATH in modextrapaths
a15f194 
And similar test for `sanity_check_paths`.

Intended to avoid issues fixed in easybuilders#13385
Flamefire added a commit to Flamefire/easybuild-easyconfigs that referenced this pull request Sep 24, 2025
@Flamefire
Add test for duplicate PYTHONPATH in modextrapaths
dcf14e1 
And similar test for `sanity_check_paths`.

Intended to avoid issues fixed in easybuilders#13385
Flamefire added a commit to Flamefire/easybuild-easyconfigs that referenced this pull request Oct 15, 2025
@Flamefire
Add test for duplicate PYTHONPATH in modextrapaths
a1eacbd 
And similar test for `sanity_check_paths`.

Intended to avoid issues fixed in easybuilders#13385
Flamefire added a commit to Flamefire/easybuild-easyconfigs that referenced this pull request Nov 24, 2025
@Flamefire
Add test for duplicate PYTHONPATH in modextrapaths
89d52bb 
And similar test for `sanity_check_paths`.

Intended to avoid issues fixed in easybuilders#13385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Failing to build PyQt5-5.9.2-intel-2018a-Python-3.6.4

2 participants

@Flamefire @boegel