-
Notifications
You must be signed in to change notification settings - Fork 772
use GTK2 and GTK3 as dependencies rather than GTK+ for easyconfigs using GCC/10.3.0 toolchain #13900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use GTK2 and GTK3 as dependencies rather than GTK+ for easyconfigs using GCC/10.3.0 toolchain #13900
Conversation
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfgrimm GTK+-2.24.33-GCCcore-10.3.0.eb was included in the EasyBuild v4.4.2 release, so we shouldn't remove that... Changing the GIMP dependency is fine though.
GTK+-3.24.29-GCCcore-10.3.0.eb can be removed, since that's not included with a release yet.
Micket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (this was exactly the same changes as I was just preparing 👍 )
…asyconfigs into split_gtk+_into_gtk2_gtk3
|
@boegelbot please test @ generoso |
|
@Micket: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 912595058 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @Micket |
Micket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Test report by @boegelbot |
|
Test report by @boegel |
|
Test report by @Micket |
|
Going in, thanks @jfgrimm! |
|
Test report by @boegel |
Update instances where GTK+ was used in the GCC 10.3.0 toolchain generation ECs to use GTK2 or GTK3 (requires #13893)