Skip to content

Conversation

@jfgrimm
Copy link
Member

@jfgrimm jfgrimm commented Sep 3, 2021

Update instances where GTK+ was used in the GCC 10.3.0 toolchain generation ECs to use GTK2 or GTK3 (requires #13893)

boegel
boegel previously requested changes Sep 3, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfgrimm GTK+-2.24.33-GCCcore-10.3.0.eb was included in the EasyBuild v4.4.2 release, so we shouldn't remove that... Changing the GIMP dependency is fine though.

GTK+-3.24.29-GCCcore-10.3.0.eb can be removed, since that's not included with a release yet.

@boegel boegel changed the title Split GTK+ into GTK2 and GTK3 for GCC 10.3.0 toolchain use GTK2 and GTK3 as dependencies rather than GTK+ for easyconfigs using GCCcore/10.3.0 toolchain Sep 3, 2021
@boegel boegel changed the title use GTK2 and GTK3 as dependencies rather than GTK+ for easyconfigs using GCCcore/10.3.0 toolchain use GTK2 and GTK3 as dependencies rather than GTK+ for easyconfigs using GCC/10.3.0 toolchain Sep 3, 2021
Micket
Micket previously approved these changes Sep 3, 2021
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (this was exactly the same changes as I was just preparing 👍 )

@Micket
Copy link
Contributor

Micket commented Sep 3, 2021

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on generoso

PR test command 'EB_PR=13900 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_13900 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 18285

Test results coming soon (I hope)...

Details

- notification for comment with ID 912595058 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket
Copy link
Contributor

Micket commented Sep 3, 2021

Test report by @Micket
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/6dd052c5f6c4afe284f4157119aff926 for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3b59064aa7720eb11c328dbafaec0c17 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 3, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3129.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/6735294daa0c50c44a7e470bcc6cd5e8 for a full test report.

@Micket
Copy link
Contributor

Micket commented Sep 3, 2021

Test report by @Micket
SUCCESS
Build succeeded for 23 out of 23 (1 easyconfigs in total)
vera-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/b812d5d90a4e2d0ed43fdf67371b2389 for a full test report.

@Micket
Copy link
Contributor

Micket commented Sep 3, 2021

Going in, thanks @jfgrimm!

@Micket Micket merged commit 4fbf1a0 into easybuilders:develop Sep 3, 2021
@boegel
Copy link
Member

boegel commented Sep 3, 2021

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (4 easyconfigs in total)
node3570.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/2174205df44c17960bba10eccefad286 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants