Skip to content

Conversation

@SIB-software
Copy link
Contributor

(created using eb --new-pr)

@boegel boegel changed the title Add patch for hard-coded checksum value of downloaded source file in the source code Add patch for hard-coded checksum value of downloaded source file in the source code of RDKit 2021.03.4 Jan 19, 2022
@boegel boegel added the bug fix label Jan 19, 2022
@boegel boegel added this to the 4.5.2 milestone Jan 19, 2022
@boegel boegel changed the title Add patch for hard-coded checksum value of downloaded source file in the source code of RDKit 2021.03.4 add patch for hard-coded checksum value of downloaded source file in the source code of RDKit 2021.03.4 Jan 19, 2022
@robinengler
Copy link
Contributor

Thanks @boegel for reviewing this PR.

Would the following description for the patch be OK ? (or is it too long)

As part of its installation, RDKit downloads a font package from https://fonts.google.com
and checks its md5sum. It appears the font package was modified and therefore a new md5sum
must be used. The authors of RDKit have updated the md5sum in the source code of RDKit but
no backward fix was made for already existing releases. This patch updates the md5 checksum
to the its new value.
Author: Robin Engler, SIB Swiss Institute for Bioinformatics
--- rdkit-Release_2021_03_4/Code/GraphMol/MolDraw2D/CMakeLists.txt.orig	2022-01-17 13:56:43.780726092 +0100
+++ rdkit-Release_2021_03_4/Code/GraphMol/MolDraw2D/CMakeLists.txt	2022-01-17 13:57:02.668646178 +010
...

@boegel
Copy link
Member

boegel commented Jan 19, 2022

Thanks @boegel for reviewing this PR.

Would the following description for the patch be OK ? (or is it too long)

As part of its installation, RDKit downloads a font package from https://fonts.google.com
and checks its md5sum. It appears the font package was modified and therefore a new md5sum
must be used. The authors of RDKit have updated the md5sum in the source code of RDKit but
no backward fix was made for already existing releases. This patch updates the md5 checksum
to the its new value.
Author: Robin Engler, SIB Swiss Institute for Bioinformatics
--- rdkit-Release_2021_03_4/Code/GraphMol/MolDraw2D/CMakeLists.txt.orig	2022-01-17 13:56:43.780726092 +0100
+++ rdkit-Release_2021_03_4/Code/GraphMol/MolDraw2D/CMakeLists.txt	2022-01-17 13:57:02.668646178 +010
...

@robinengler Looks perfect to me

@boegel
Copy link
Member

boegel commented Jan 20, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14743 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14743 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7931

Test results coming soon (I hope)...

Details

- notification for comment with ID 1017201116 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/6621c82bbdc005365e1300571d0de08b for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 21, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2684.swalot.os - Linux UNKNOWN UNKNOWN, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/0e338d1ac92cc89b09f12c3086f49642 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 21, 2022

Going in, thanks @SIB-software!

@boegel boegel merged commit f497a23 into easybuilders:develop Jan 21, 2022
@robinengler robinengler deleted the 20220117153155_new_pr_RDKit2021034 branch January 21, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants