Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Jan 19, 2022

fix for failing easyconfig tests, introduced in #14591:

ERROR: test_pr_sanity_check_paths (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure a custom sanity_check_paths value is specified for easyconfigs that use a generic easyblock.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 1030, in test_pr_sanity_check_paths
    bundle_sanity_check_components = ec['sanity_check_components'] or ec['sanity_check_all_components']
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 125, in new_ec_method
    return ec_method(self, key, *args, **kwargs)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 1751, in __getitem__
    raise EasyBuildError("Use of unknown easyconfig parameter '%s' when getting parameter value", key)
EasyBuildError: "Use of unknown easyconfig parameter 'sanity_check_components' when getting parameter value"

…en Bundle easyblock is used in test_pr_sanity_check_paths
@boegel boegel added the bug fix label Jan 19, 2022
@boegel boegel added this to the 4.5.2 milestone Jan 19, 2022
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 223db48 into easybuilders:develop Jan 19, 2022
@boegel boegel deleted the fix_test_pr_sanity_check_paths branch January 19, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants