trim test configurations for easyconfigs test suite: only test with Python 2.7 + 3.6 and Lmod 7.x + 8.x #14881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ython 2.7 + 3.6 and Lmod 7.x + 8.x
Contributor
|
The PR is expecting the two excluded tests (Lmod-7 + Tcl). Those tests are not running, so they should not be expected. I'll close an reopen this PR to see if that refreshes the list of expected tests. |
Contributor
|
Ok, the required checks have to updated in this branch protection rules. @boegel I cannot change that 🙂 |
Member
Author
|
@lexming fixed! |
Contributor
|
Going in, thanks @boegel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #14857 were a bit ambitious, testing with a wide range of Python 3.x versions quickly leads to a large backlog for easyconfig PRs...
Only testing with Python 2.7 + 3.6 (most popular Python 3.x version), and no longer testing with Lmod 6.x (deprecated for a while, see easybuilders/easybuild-framework#3077) should be enough...