Skip to content

Conversation

@Micket
Copy link
Contributor

@Micket Micket commented Aug 19, 2022

(created using eb --new-pr)
Briefly discussed in the last zoom meeting; how about just getting rid of oracle java for 8 as well, since it seems we never stop updating it..

@Micket Micket added the update label Aug 19, 2022
@Micket
Copy link
Contributor Author

Micket commented Aug 19, 2022

Things got so ugly with the mess of version strings i just went for what they use upstream.

But.. i'm not sure what we should do with the modulerc wrapper things. I just made both variants.

@Micket
Copy link
Contributor Author

Micket commented Aug 19, 2022

So, other maintainers (or anyone else): Please have write your opinions on the naming of these.

@branfosj
Copy link
Member

I'm happy to go with the 8u345 for the version. I am wondering if we should leave the 1.8 wrapper as Oracle Java and use the 8 wrapper for the OpenJDK variant.

@boegel boegel added this to the 4.x milestone Aug 22, 2022
@boegel boegel added the change label Aug 22, 2022
@Micket
Copy link
Contributor Author

Micket commented Aug 23, 2022

Due to EB code like this

                # use version of Java wrapper rather than full Java version
                if dep == 'Java':
                    dep_ver = '.'.join(dep_ver.split('.')[:2])

i'm just going to change to 8.345 format instead, and leave 1.8 as is.

@Micket
Copy link
Contributor Author

Micket commented Aug 23, 2022

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
alvis-c1 - Linux Rocky Linux 8.5, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/8fb8175903675a698a1c68a721d29003 for a full test report.

@boegel boegel changed the title Use OpenJDK for Java 8 {lang}[system} Java/8 (OpenJDK) Aug 31, 2022
@easybuilders easybuilders deleted a comment from boegelbot Aug 31, 2022
@boegel
Copy link
Member

boegel commented Aug 31, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16062 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16062 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9095

Test results coming soon (I hope)...

Details

- notification for comment with ID 1233278974 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Aug 31, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
easybuild2.novalocal - Linux CentOS Stream 8, POWER, IBM pSeries (emulated by qemu) (power9le), Python 3.6.8
See https://gist.github.com/af24ef641989de89cb2a5218a702deb4 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/fe85f99c5573bba047478036099f1abe for a full test report.

@boegel
Copy link
Member

boegel commented Aug 31, 2022

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
fair-mastodon-c6g-2xlarge-0001 - Linux Rocky Linux 8.5, AArch64, ARM UNKNOWN (graviton2), Python 3.6.8
See https://gist.github.com/c2b1c83a475675d3986a8a84863afafc for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Aug 31, 2022

Going in, thanks @Micket!

@boegel boegel merged commit 3251176 into easybuilders:develop Aug 31, 2022
@Micket Micket deleted the 20220819022405_new_pr_Java8u345 branch April 21, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants