-
Notifications
You must be signed in to change notification settings - Fork 772
{lang}[system} Java/8 (OpenJDK) #16062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{lang}[system} Java/8 (OpenJDK) #16062
Conversation
|
Things got so ugly with the mess of version strings i just went for what they use upstream. But.. i'm not sure what we should do with the modulerc wrapper things. I just made both variants. |
|
So, other maintainers (or anyone else): Please have write your opinions on the naming of these. |
|
I'm happy to go with the |
|
Due to EB code like this i'm just going to change to |
|
Test report by @Micket |
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 1233278974 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegel |
|
Test report by @boegelbot |
|
Test report by @boegel |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Going in, thanks @Micket! |
(created using
eb --new-pr)Briefly discussed in the last zoom meeting; how about just getting rid of oracle java for 8 as well, since it seems we never stop updating it..