Skip to content

Conversation

@smoors
Copy link
Contributor

@smoors smoors commented Oct 13, 2022

(created using eb --new-pr)

@smoors smoors added the update label Oct 13, 2022
@boegel boegel added this to the 4.x milestone Oct 13, 2022
boegel
boegel previously approved these changes Oct 13, 2022
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Oct 13, 2022

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16401 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16401 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9276

Test results coming soon (I hope)...

Details

- notification for comment with ID 1277852274 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/69dfbc6f2364d20eefe7d1beffe8df84 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 14, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3102.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/cd6371a2a7241568d1b001e55efd0abc for a full test report.

@boegel
Copy link
Member

boegel commented Oct 14, 2022

@boegelbot please test @ jsc-zen2
CORE_CNT=16

@boegel boegel modified the milestones: 4.x, next release (4.6.2?) Oct 14, 2022
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16401 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_16401 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1694

Test results coming soon (I hope)...

Details

- notification for comment with ID 1278595482 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/9e8e6072047b7babb13e6fa02a777f8d for a full test report.

@casparvl
Copy link
Contributor

casparvl commented Oct 14, 2022

What am I missing here... I seem to be the only one who gets:

== Temporary log file in case of crash /scratch-shared/casparl/eb-1a3q0kw8/easybuild-mr1k3u1d.log
ERROR: Failed to process easyconfig /scratch-shared/casparl/eb-1a3q0kw8/files_pr16401/p/PyTorch/PyTorch-1.12.0-foss-2022a.eb: Parsing easyconfig file failed: name 'GITHUB_RELEASE' is not defined (line 10)

when trying to build this PR?

@smoors
Copy link
Contributor Author

smoors commented Oct 14, 2022

@casparvl GITHUB_RELEASE is a new template, see easybuilders/easybuild-framework#4084

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 25 out of 25 (1 easyconfigs in total)
centos7.lan - Linux CentOS Linux 7.9.2009, x86_64, Intel Core Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/e01fae91dfc7441f01643b723ab32b46 for a full test report.

@Flamefire
Copy link
Contributor

I'd suggest to use 1.12.1, shouldn't be much potential for breaking stuff but IMO makes more sense as this is a newly added 1.12 EC: pytorch/pytorch@v1.12.0...v1.12.1

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Oct 16, 2022

Going in, thanks @smoors!

@boegel boegel merged commit 28ce93d into easybuilders:develop Oct 16, 2022
@boegel
Copy link
Member

boegel commented Oct 16, 2022

I'd suggest to use 1.12.1, shouldn't be much potential for breaking stuff but IMO makes more sense as this is a newly added 1.12 EC: pytorch/[email protected]

I'll merge this as is, but we can/should indeed open a separate PR for PyTorch 1.12.1...

@Flamefire
Copy link
Contributor

I'll merge this as is, but we can/should indeed open a separate PR for PyTorch 1.12.1...

I'll do that as soons as I got the tests to pass

@Flamefire
Copy link
Contributor

I finished the 1.12.1 ECs with pretty much all tests passing and a bit improved EC: #16484 and #16453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants