Skip to content

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Nov 7, 2022

@lexming lexming added the new label Nov 7, 2022
@lexming
Copy link
Contributor Author

lexming commented Nov 7, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16562 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16562 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9446

Test results coming soon (I hope)...

Details

- notification for comment with ID 1305462746 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3033decf729037fe01561fa5bbc9649f for a full test report.

@boegel boegel added enhancement and removed new labels Dec 7, 2022
@boegel boegel added this to the next release (4.7.0) milestone Dec 7, 2022
@boegel
Copy link
Member

boegel commented Dec 9, 2022

@lexming PR title suggests changes to IPython, but only JupyterLab easyconfig is touched?

@lexming
Copy link
Contributor Author

lexming commented Dec 9, 2022

@boegel the Lmod extensions have their own easyconfigs:

  • jupyterlmod-3.0.0-GCCcore-10.3.0.eb is for IPython
  • jupyterlab-lmod-1.0.2-GCCcore-10.3.0.eb is for JupyterLab

@lexming
Copy link
Contributor Author

lexming commented Dec 9, 2022

@boegel after the sync with develop, the only extra thing that remains in JupyterLab is the split of jupyter-server into its own easyconfig. This is harmless and I did it to keep parity with newer toolchains, we already have the same arrangement in GCCcore/11.3.0. If you prefer a different PR for that change let me know.

@lexming lexming added the new label Dec 9, 2022
@boegel
Copy link
Member

boegel commented Dec 12, 2022

@lexming Wasn't it your intention of adding jupyterlmod as a dependency to IPython?

@lexming
Copy link
Contributor Author

lexming commented Dec 12, 2022

@boegel jupyterlmod depends on IPython because it's an extension of IPython, it works without JupyterLab.

@boegel boegel changed the title add Lmod extentions to IPython v7.25.0 and JupyterLab v3.2.8 {tools}[GCCcore/10.3.0] jupyterlab-lmod v1.0.2, jupyterlmod v3.0.0, jupyter-server v1.13.4 + add jupyter-server dependency to JupyterLab Dec 12, 2022
@boegel
Copy link
Member

boegel commented Dec 12, 2022

Test report by @boegel
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/6c78da6fe71d7e0656539be1909176be for a full test report.

edit: @lexming

RuntimeError: npm dependencies failed to install
error An unexpected error occurred: "EACCES: permission denied, open '/arcanine/scratch/gent/vo/000/gvo00002/vsc40023/easybuild_tests/RHEL8/skylake-ib/software/jupyterlab-lmod/1.0.2-GCCcore-10.3.0/share/jupyter/lab/staging/yarn.lock'".

@lexming
Copy link
Contributor Author

lexming commented Dec 12, 2022

@boegel that's a weird issue, the permission error happens inside the installation directory of jupyterlab-lmod during its postinstall step. So it should already exist and be writable. Did something else fail before that point?

@boegel
Copy link
Member

boegel commented Dec 15, 2022

@boegel that's a weird issue, the permission error happens inside the installation directory of jupyterlab-lmod during its postinstall step. So it should already exist and be writable. Did something else fail before that point?

@lexming That setup is configured with --read-only-installdir, that's likely related...

@lexming
Copy link
Contributor Author

lexming commented May 9, 2023

Superseded by #17888

@lexming lexming closed this May 9, 2023
@lexming lexming deleted the 20221107110953_new_pr_jupyterlmod300 branch May 9, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants