Skip to content

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Nov 7, 2022

@lexming lexming added the new label Nov 7, 2022
@boegelbot

This comment was marked as outdated.

@lexming
Copy link
Contributor Author

lexming commented Nov 25, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16563 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16563 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9671

Test results coming soon (I hope)...

Details

- notification for comment with ID 1327387145 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/42db568f30a3df95e6e53726bcfc31fc for a full test report.

@casparvl
Copy link
Contributor

jupyterlab-lmod doesn't build for me, and I don't get any proper logs to find out why...

== 2023-02-10 17:10:29,688 build_log.py:171 ERROR EasyBuild crashed with an error (at easybuild/base/exceptions.py:126 in __init__): cmd " mkdir -p /home/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab && JUPYTERLAB_DIR=/home/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab jupyter labextension install jupyterlab-lmod-1.0.2.tgz " exited with exit code 1 and output:
Building jupyterlab assets (production, minimized)
An error occurred.
RuntimeError: JupyterLab failed to build
See the log file for details:  /scratch-shared/casparl/eb-kp55xg0r/jupyterlab-debug-tt0xbht5.log

But the /scratch-shared/casparl/eb-kp55xg0r/jupyterlab-debug-tt0xbht5.log logfile is empty...

@casparvl
Copy link
Contributor

I managed to get a more extensive error output by dumping the environment script (--dump-env-script), going into the builddir, and running

JUPYTERLAB_DIR=/home/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab jupyter labextension install --debug jupyterlab-lmod-1.0.2.tgz

manually. The --debug flag prints debugging output:

Yarn configuration loaded.
Building jupyterlab assets (production, minimized)
> node /home/casparl/.local/easybuild/RHEL8/2022/software/JupyterLab/3.5.0-GCCcore-11.3.0/lib/python3.10/site-packages/jupyterlab/staging/yarn.js install --non-interactive
/yarn install v1.21.1
[1/5] Validating package.json...
[2/5] Resolving packages...
success Already up-to-date.
Done in 0.42s.

> node /home/casparl/.local/easybuild/RHEL8/2022/software/JupyterLab/3.5.0-GCCcore-11.3.0/lib/python3.10/site-packages/jupyterlab/staging/yarn.js yarn-deduplicate -s fewer --fail
|yarn run v1.21.1
$ /gpfs/home4/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab/staging/node_modules/.bin/yarn-deduplicate -s fewer --fail
Done in 0.27s.

> node /home/casparl/.local/easybuild/RHEL8/2022/software/JupyterLab/3.5.0-GCCcore-11.3.0/lib/python3.10/site-packages/jupyterlab/staging/yarn.js run build:prod:minimize
\yarn run v1.21.1
$ webpack --config webpack.prod.minimize.config.js
[webpack-cli] SyntaxError: Invalid regular expression: /(\p{Uppercase_Letter}+|\p{Lowercase_Letter}|\d)(\p{Uppercase_Letter}+)/: Invalid property name
    at pathToArgumentName (/gpfs/home4/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab/staging/node_modules/webpack/lib/cli.js:66:4)
    at addFlag (/gpfs/home4/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab/staging/node_modules/webpack/lib/cli.js:170:16)
    at traverse (/gpfs/home4/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab/staging/node_modules/webpack/lib/cli.js:243:21)
    at traverse (/gpfs/home4/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab/staging/node_modules/webpack/lib/cli.js:299:23)
    at traverse (/gpfs/home4/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab/staging/node_modules/webpack/lib/cli.js:248:24)
    at Object.getArguments (/gpfs/home4/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab/staging/node_modules/webpack/lib/cli.js:308:2)
    at WebpackCLI.getBuiltInOptions (/gpfs/home4/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab/staging/node_modules/webpack-cli/lib/webpack-cli.j
s:681:47)
    at loadCommandByName (/gpfs/home4/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab/staging/node_modules/webpack-cli/lib/webpack-cli.js:838:38)
    at Command.<anonymous> (/gpfs/home4/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab/staging/node_modules/webpack-cli/lib/webpack-cli.js:1462:23
)
    at Command.listener [as _actionHandler] (/gpfs/home4/casparl/.local/easybuild/RHEL8/2022/software/jupyterlab-lmod/1.0.2-GCCcore-11.3.0/share/jupyter/lab/staging/node_modules/webpack-cli/node_modu
les/commander/index.js:922:31)
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

JupyterLab failed to build
Traceback (most recent call last):

  File "/home/casparl/.local/easybuild/RHEL8/2022/software/JupyterLab/3.5.0-GCCcore-11.3.0/lib/python3.10/site-packages/jupyterlab/debuglog.py", line 47, in debug_logging
    yield

  File "/home/casparl/.local/easybuild/RHEL8/2022/software/JupyterLab/3.5.0-GCCcore-11.3.0/lib/python3.10/site-packages/jupyterlab/labextensions.py", line 153, in start
    build(

  File "/home/casparl/.local/easybuild/RHEL8/2022/software/JupyterLab/3.5.0-GCCcore-11.3.0/lib/python3.10/site-packages/jupyterlab/commands.py", line 506, in build
    return handler.build(

  File "/home/casparl/.local/easybuild/RHEL8/2022/software/JupyterLab/3.5.0-GCCcore-11.3.0/lib/python3.10/site-packages/jupyterlab/commands.py", line 722, in build
    raise RuntimeError(msg)

RuntimeError: JupyterLab failed to build

An error occurred.

No clue yet what's wrong. I might try reinstalling nodejs, as I think you may have used one of your previous PR's for that - and I'm not sure if we have the same installation for that now (we might have had our own EasyConfig). It doesn't immediately look like a nodejs problem though...

@casparvl
Copy link
Contributor

Ok, reinstalling nodejs helped. Not sure what was wrong in our original installation, but I don't care enough to find out. Anyway, I'll upload a test report for this PR :)

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
int4 - Linux Rocky Linux 8.7, x86_64, AMD EPYC 7F72 24-Core Processor, Python 3.6.8
See https://gist.github.com/6b575c97253da40359d5b97942797341 for a full test report.

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@casparvl
Copy link
Contributor

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16563 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_16563 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2178

Test results coming soon (I hope)...

Details

- notification for comment with ID 1426118916 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/00541c8a2c0fd919ed3bf284cca2b7df for a full test report.

@casparvl casparvl added this to the next release (4.7.1?) milestone Feb 10, 2023
@casparvl
Copy link
Contributor

Going in, thanks @lexming!

@casparvl casparvl merged commit 14cfd8e into easybuilders:develop Feb 10, 2023
@lexming lexming deleted the 20221107111202_new_pr_jupyterlmod300 branch February 10, 2023 23:43
@lexming
Copy link
Contributor Author

lexming commented Feb 10, 2023

@casparvl your initial error is related to issue jupyterlab/jupyterlab#10487, which we fixed in nodejs #16529 . That's why a rebuild of nodejs solved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants