Skip to content

Conversation

@ThomasHoffmann77
Copy link
Contributor

(created using eb --new-pr)

@smoors
Copy link
Contributor

smoors commented Nov 22, 2022

the new sources fix the version, so this seems a good change to me.

diff -ur dllogger-1.0.0/dllogger/__init__.py new/dllogger-1.0.0/dllogger/__init__.py
--- dllogger-1.0.0/dllogger/__init__.py>2022-01-24 13:42:17.000000000 +0100
+++ new/dllogger-1.0.0/dllogger/__init__.py>2022-03-31 13:49:06.000000000 +0200
@@ -22,7 +22,7 @@
     JSONStreamBackend,
 )
·
-__version__ = "0.1.0"
+__version__ = "1.0.0"
·
·
 class DLLoggerNotInitialized(Exception):
diff -ur dllogger-1.0.0/README.md new/dllogger-1.0.0/README.md
--- dllogger-1.0.0/README.md>···2022-01-24 13:42:17.000000000 +0100
+++ new/dllogger-1.0.0/README.md>···2022-03-31 13:49:06.000000000 +0200
@@ -19,8 +19,7 @@
 To install DLLogger, run (separate commands):
·
 ` ``` `bash
-pip install nvidia-pyindex
-pip install nvidia-dllogger
+pip install git+https://github.com/NVIDIA/dllogger#egg=dllogger
 ` ``` `
·
 ## Quick Start Guide
@@ -110,4 +109,4 @@
 ` ``` `python
 from dllogger import Logger
 logger = Logger(backends=BACKEND_LIST)
-` ``` `
\ No newline at end of file
+` ``` `

@smoors smoors added the bug fix label Nov 22, 2022
@smoors
Copy link
Contributor

smoors commented Nov 22, 2022

@boegelbot: please test @ generoso EB_ARGS="--force-download"

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=16694 EB_ARGS="--force-download" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16694 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9643

Test results coming soon (I hope)...

Details

- notification for comment with ID 1324260885 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/5a17aa72adf5284e77b83056e4f31c1f for a full test report.

@smoors smoors added this to the next release (4.6.3?) milestone Nov 23, 2022
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Nov 23, 2022

Going in, thanks @ThomasHoffmann77!

@smoors smoors merged commit 2e6340b into easybuilders:develop Nov 23, 2022
@boegel boegel changed the title fix dllogger checksum fix checksum for dlllogger extension in OpenFold v1.0.0 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants