Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Nov 22, 2022

(created using eb --new-pr)

Without this change, pip check fails with:

pyqt-builder 1.14.0 has requirement sip<7,>=6.7, but you have sip 5.5.0.

That's problematic when installing stuff on top of PyQt5, like the QtPy-2.3.0-GCCcore-11.3.0.eb I'm looking into.

@boegel boegel requested a review from akesandgren November 22, 2022 16:24
@boegel boegel added the bug fix label Nov 22, 2022
@boegel boegel added this to the next release (4.6.3?) milestone Nov 22, 2022
@boegel
Copy link
Member Author

boegel commented Nov 22, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16703 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16703 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9633

Test results coming soon (I hope)...

Details

- notification for comment with ID 1323948625 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@jfgrimm
Copy link
Member

jfgrimm commented Nov 22, 2022

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node131.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6138 CPU @ 2.00GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/5634ebae05d8db12af222ab62817287d for a full test report.

@boegel
Copy link
Member Author

boegel commented Nov 22, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3106.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/d211b0e1550377148f27ff51ab2397de for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/6cc1e674dc031cfa75056c5e07cc978c for a full test report.

Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm merged commit e290032 into easybuilders:develop Nov 22, 2022
@boegel boegel deleted the 20221122172312_new_pr_PyQt55155 branch November 22, 2022 21:06
@mboisson
Copy link
Contributor

How is this working, since SIP 5.5.0 is hard-coded to not support Python 3.10 ?

SIP/sip-5.5.0/build/lib.linux-x86_64-3.9/sipbuild/py_versions.py:LAST_SUPPORTED_MINOR = 9

For my own build, I had to patch this file to change it to 10 to get Python 3.10 to work.

@boegel
Copy link
Member Author

boegel commented Jan 23, 2023

@mboisson Please open an issue on that, it's impossible to follow up on things in merged PRs...

@mboisson
Copy link
Contributor

ok, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants