Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Nov 23, 2022

(created using eb --new-pr)

@boegel boegel added the update label Nov 23, 2022
@boegel boegel added this to the next release (4.6.3?) milestone Nov 23, 2022
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple issues with this way of installing nodejs, please check #16529

@boegel
Copy link
Member Author

boegel commented Nov 23, 2022

There are multiple issues with this way of installing nodejs, please check #16529

fixed in 46b4c40

@boegel
Copy link
Member Author

boegel commented Nov 23, 2022

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16713 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16713 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9654

Test results coming soon (I hope)...

Details

- notification for comment with ID 1325075856 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/1cf0d4e6dd9a65da9ca3c993778d0573 for a full test report.

@lexming
Copy link
Contributor

lexming commented Nov 23, 2022

Going in, thanks @boegel !

@lexming lexming merged commit 5d3bdf5 into easybuilders:develop Nov 23, 2022
@boegel boegel deleted the 20221123105233_new_pr_nodejs18121 branch November 23, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants