Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Dec 7, 2022

(created using eb --new-pr)

It looks like the 0.05-alpha tag in was changed, since the contents of the source tarball are different now (notebooks were removed):

$ diff -ru cell2location-0.05-alpha.old cell2location-0.05-alpha.new
Only in cell2location-0.05-alpha.old/docs/notebooks: cell2location_estimating_signatures.ipynb
Only in cell2location-0.05-alpha.old/docs/notebooks: cell2location_short_demo.ipynb
Only in cell2location-0.05-alpha.old/docs/notebooks: cell2location_short_demo_colab.ipynb
Only in cell2location-0.05-alpha.old/docs/notebooks: cell2location_short_demo_downstream.ipynb
Only in cell2location-0.05-alpha.old/docs/notebooks: results
Only in cell2location-0.05-alpha.old: notebooks

Probably somehow related to BayraktarLab/cell2location@d4e4323

@boegel boegel added the bug fix label Dec 7, 2022
@boegel boegel added this to the next release (4.7.0) milestone Dec 7, 2022
@boegel
Copy link
Member Author

boegel commented Dec 7, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=16819 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16819 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9706

Test results coming soon (I hope)...

Details

- notification for comment with ID 1341356077 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/5a0cb775b59df6615222604bb0607011 for a full test report.

@lexming
Copy link
Contributor

lexming commented Dec 8, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=16819 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16819 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9720

Test results coming soon (I hope)...

Details

- notification for comment with ID 1342783214 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/2d4167f9d2917082393e8b237a52119e for a full test report.

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Dec 8, 2022

Going in, thanks @boegel !

@lexming lexming merged commit 981d872 into easybuilders:develop Dec 8, 2022
@lexming lexming changed the title fix checksum for cell2location 0.05-alpha fix checksum for cell2location 0.05-alpha and add missing build dependency on flex Dec 8, 2022
@boegel boegel deleted the 20221207185555_new_pr_cell2location005alpha branch December 9, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants