Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Jun 2, 2023

WIP because sdist tests fails with Python 3.11, because the CVS easyconfigs are not being included (cfr. #10326)

requires:

@Micket
Copy link
Contributor

Micket commented Jun 4, 2023

Looks like disabling pruning is no longer allowed, CVS files are excluded despite

[sdist]
# Don't remove CVS and RCS directories
prune = 0

sheesh python..

@branfosj
Copy link
Member

branfosj commented Jun 4, 2023

This is because, for setuptools >= 60, we are getting setuptools.setup instead of distutils.core.setup. This is part of the deprecation of distutils and moving people over to setuptools. From what I can tell, setuptools.setup does not have the prune option.

Starting point:

$ pip list
Package    Version
---------- -------
pip        23.0.1
setuptools 66.1.1

No CVS in dist:

  • python3 setup.py sdist
  • pip install setuptools==60.0.0 && python3 setup.py sdist

CVS in dist:

  • SETUPTOOLS_USE_DISTUTILS=stdlib python3 setup.py sdist
  • pip install setuptools==59.1.0 && python3 setup.py sdist
  • pip uninstall setuptools && python3 setup.py sdist

@branfosj
Copy link
Member

branfosj commented Jun 4, 2023

Also, from the setuptools release notes:

  • v59.7.0: Require Python 3.7
  • v60.0.0: Setuptools once again makes its local copy of distutils the default. To override, set SETUPTOOLS_USE_DISTUTILS=stdlib.

@branfosj
Copy link
Member

branfosj commented Jun 4, 2023

From https://packaging.python.org/en/latest/guides/using-manifest-in/

After processing the MANIFEST.in file, setuptools removes the build/ directory as well as any directories named RCS, CVS, or .svn from the sdist, and it adds a PKG-INFO file and an *.egg-info directory. This behavior cannot be changed with MANIFEST.in.

I also could not find any indication in that documentation on how to stop it happening.

@boegel boegel added this to the next release (4.7.3?) milestone Jun 4, 2023
@boegel boegel modified the milestones: 4.8.0, release after 4.8.0 Jul 6, 2023
@boegel boegel modified the milestones: 4.8.1, release after 4.8.1 Sep 9, 2023
@boegel boegel marked this pull request as ready for review October 26, 2023 08:05
@boegel
Copy link
Member Author

boegel commented Oct 26, 2023

@Micket Let's merge?

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit a918f71 into easybuilders:develop Oct 26, 2023
@boegel boegel deleted the tests_python311 branch October 27, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants