Skip to content

Conversation

@appolloford
Copy link
Contributor

@appolloford appolloford commented Aug 29, 2023

(created using eb --new-pr)

@Micket Micket added the new label Aug 29, 2023
@Micket Micket added this to the next release (4.8.1?) milestone Aug 29, 2023
@boegelbot

This comment was marked as outdated.

@boegelbot

This comment was marked as outdated.

@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 30 out of 34 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/4a07cf9d9975e951682ccf8b44a7ea3e for a full test report.

@verdurin
Copy link
Member

That's actually a weird failure with LLVM:

-- Looking for __x86_64__
-- Looking for __x86_64__ - found
-- Found Git: /bin/git (found version "1.8.3.1")
-- Targeting X86
CMake Error at CMakeLists.txt:1171 (add_subdirectory):
  add_subdirectory given source
  "/dev/shm/LLVM/16.0.6/GCCcore-12.3.0/llvm-16.0.6.src/../third-party/unittest"
  which is not an existing directory.


-- Registering ExampleIRTransforms as a pass plugin (static build: OFF)
-- Registering Bye as a pass plugin (static build: OFF)
-- Configuring incomplete, errors occurred!
 (at easybuild/tools/run.py:643 in parse_cmd_output)

@branfosj
Copy link
Member

branfosj commented Aug 31, 2023

Test report by @branfosj
FAILED
Build succeeded for 8 out of 9 (1 easyconfigs in total)
bear-pg0105u03b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/2c73905acc7d4b2065768bdb6a4ec4e6 for a full test report.

edit:

CMake Error at qtbase/src/corelib/CMakeLists.txt:1232 (message):
  CMake was not built with zstd support.  Rebuild CMake or set
  QT_AVOID_CMAKE_ARCHIVING_API=ON.

@verdurin
Copy link
Member

That's actually a weird failure with LLVM:

-- Looking for __x86_64__
-- Looking for __x86_64__ - found
-- Found Git: /bin/git (found version "1.8.3.1")
-- Targeting X86
CMake Error at CMakeLists.txt:1171 (add_subdirectory):
  add_subdirectory given source
  "/dev/shm/LLVM/16.0.6/GCCcore-12.3.0/llvm-16.0.6.src/../third-party/unittest"
  which is not an existing directory.


-- Registering ExampleIRTransforms as a pass plugin (static build: OFF)
-- Registering Bye as a pass plugin (static build: OFF)
-- Configuring incomplete, errors occurred!
 (at easybuild/tools/run.py:643 in parse_cmd_output)

Re-trying now with the easy block required for LLVM.

@branfosj
Copy link
Member

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=18683 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_18683 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11598

Test results coming soon (I hope)...

Details

- notification for comment with ID 1701045670 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/30ebca47bccf0800db3e5f1cc1b862a8 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 0 out of 3 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/cb4a26cb2a6545dce655de3d9845e78f for a full test report.

@branfosj
Copy link
Member

Test report by @branfosj
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux Ubuntu 20.04.2 LTS (Focal Fossa), x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/branfosj/06ef3ae2a7ec492f241f40c42028884d for a full test report.

('FFmpeg', '6.0'),
('X11', '20230603'),
('fontconfig', '2.14.2'),
('html5lib', '1.1'), # WebEngine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
('html5lib', '1.1'), # WebEngine
('Python', '3.11.3'),
('Python-bundle-PyPI', '2023.06'), # WebEngine

Python-bundle-PyPi contains html5lb, so we should use that.

('Bison', '3.8.2'),
('flex', '2.6.4'),
('gperf', '3.1'),
('Python', '3.11.3'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
('Python', '3.11.3'),

@branfosj
Copy link
Member

To avoid the CMake configure error I had to add configopts += '-DQT_AVOID_CMAKE_ARCHIVING_API=ON '

I also had to add

preconfigopts = 'sed -i "23i set(Python3_ROOT_DIR \$ENV{EBROOTPYTHON})" ../qt-everywhere-src-6.5.2/qtwebengine/src/gn/CMakeLists.txt &&'
build_cmd = "cmake --build . --parallel"
install_cmd = "cmake --install . #"

The preconfigopts was needed to get the correct Python3 detected during the CMake configure of that component, which happens during the build stage.

The build_cmd and install_cmd are not the correct way of doing those. But make failed for me (make: *** No targets specified and no makefile found. Stop.).

@Micket
Copy link
Contributor

Micket commented Sep 1, 2023

@branfosj It's a CMakeNinja easyblock though (Qt insists on using Ninja, spits out a warning for CMakeMake). Does ninja also fail?

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
zen2-rockylinux-88 - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/SebastianAchilles/2147f1f53db3d66c5ce61f119aa47e03 for a full test report.

@branfosj
Copy link
Member

branfosj commented Sep 4, 2023

@branfosj It's a CMakeNinja easyblock though (Qt insists on using Ninja, spits out a warning for CMakeMake). Does ninja also fail?

easybuilders/easybuild-easyblocks#2993 will fix the issue with make being used.

@branfosj
Copy link
Member

branfosj commented Sep 4, 2023

Test report by @branfosj
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2993
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/b4c3caf1f08263b0a4c9ffe908e175f0 for a full test report.

@branfosj
Copy link
Member

branfosj commented Sep 4, 2023

Test report by @branfosj
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2993
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux Ubuntu 20.04.2 LTS (Focal Fossa), x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.8.5
See https://gist.github.com/branfosj/1189ffa740d442abb049aff1d5469ef7 for a full test report.

@boegel boegel modified the milestones: 4.8.1, release after 4.8.1 Sep 9, 2023
@akesandgren
Copy link
Contributor

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-cn1603.hpc2n.umu.se - Linux Ubuntu 22.04, x86_64, AMD EPYC 7313 16-Core Processor, 1 x NVIDIA NVIDIA A100 80GB PCIe, 525.125.06, Python 3.10.12
See https://gist.github.com/akesandgren/c69fe874a9ac9e666547ce56ddfe11bf for a full test report.

akesandgren
akesandgren previously approved these changes Sep 26, 2023
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# QT_CFLAGS_ARCH_HASWELL in cmake/QtCompilerOptimization.cmake should be patched?
# 'Qt5-5.13.1_fix-avx2.patch',
# 'Qt5-5.13.1_fix-qmake-libdir.patch',
# 'Qt5-5.15.2_fix-qtwebengine-breakpad-glibc-2.34.patch',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks these patches are not needed anymore. I may remove them in the next commit.

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @appolloford!

@akesandgren akesandgren merged commit f9a043c into easybuilders:develop Sep 26, 2023
@appolloford appolloford deleted the 20230829161935_new_pr_Qt6652 branch March 31, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants