-
Notifications
You must be signed in to change notification settings - Fork 772
add missing required PyPy dependency for Clair3, also copy preprocess and shared subdirectories, and enhance sanity check for provided libclair3 Python package #18847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… and shared subdirectories, and enhance sanity check for provided libclair3 Python package
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 1727944212 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
@boegelbot please test @ jsc-zen2 |
|
@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 1727967571 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @boegel |
| ('zstd', '1.5.2'), | ||
| ('HTSlib', '1.15.1'), | ||
| ('libdeflate', '1.10'), | ||
| ('PyPy', '7.3.12', '-3.10', SYSTEM), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent quite a bit of time in trying to get PyPy to build from source rather than using pre-built binaries, but I didn't manage to get it fully working yet (and I gave up for now), see #18848
|
Test report by @verdurin |
verdurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
|
Going in, thanks @boegel! |
(created using
eb --new-pr)