Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Feb 7, 2024

(created using eb --new-pr)
This avoids breakage when we change the order of symlinking lib -> lib64 and running of postinstallcmds, cfr. easybuilders/easybuild-framework#4435

@boegel boegel added this to the release after 4.9.0 milestone Feb 7, 2024
@boegel boegel added the bug fix label Feb 7, 2024
@boegel
Copy link
Member Author

boegel commented Feb 7, 2024

@boegelbot please test @ generoso

@boegel boegel changed the title make sure that Brunsli libraries are installed into /lib make sure that Brunsli libraries are installed into /lib Feb 7, 2024
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19805 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19805 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12849

Test results coming soon (I hope)...

Details

- notification for comment with ID 1932563644 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member Author

boegel commented Feb 7, 2024

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3120.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/b90706a3b4aae3b347a16eccb6015364 for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors enabled auto-merge (squash) February 7, 2024 17:49
@smoors smoors merged commit d65b48b into easybuilders:develop Feb 7, 2024
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/07c326026f660a9b5447b355927c22e1 for a full test report.

@boegel boegel deleted the 20240207183544_new_pr_Brunsli01 branch February 7, 2024 18:09
@boegel boegel changed the title make sure that Brunsli libraries are installed into /lib make sure that Brunsli libraries are installed into lib Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants