Skip to content

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Feb 21, 2024

(created using eb --new-pr)

This fixes a known issue fixed in OpenMPI 4.0.3 by using the upstream fix as a patch:

In file included by /usr/include/linux/fs.h:18,
                 by /usr/include/linux/lustre/lustre_user.h:57,
                 by /usr/include/lustre/lustreapi.h:47,
                 by ../../../../ompi/mca/fs/lustre/fs_lustre.h:37,
                 by fs_lustre.c:33:
/usr/include/sys/mount.h:35:3: Error: expected identifier before numeric constant
   35 |   MS_RDONLY = 1,  /* Mount read-only.  */
      |   ^~~~~~~~~
make[2]: *** [Makefile:1866: fs_lustre.lo] Error 1

See the similar PR #19837 for 4.0.5 but seems we still use 4.0.3 in some places.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
n1170 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/c5ca302dc260be1d17561423e82daaca for a full test report.

@Micket Micket added the bug fix label Feb 26, 2024
@Micket Micket added this to the release after 4.9.0 milestone Feb 26, 2024
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Feb 26, 2024

@boegelbot please test @ generoso
EB_ARGS="OpenMPI-4.0.3-GCC-9.3.0.eb"

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=19944 EB_ARGS="OpenMPI-4.0.3-GCC-9.3.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19944 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12966

Test results coming soon (I hope)...

Details

- notification for comment with ID 1965516928 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f3732c20217fadd109ad6a1ec8940802 for a full test report.

@Micket
Copy link
Contributor

Micket commented Feb 26, 2024

Going in, thanks @Flamefire!

@Micket Micket merged commit b713f27 into easybuilders:develop Feb 26, 2024
@Flamefire Flamefire deleted the 20240221102748_new_pr_OpenMPI403 branch February 27, 2024 08:06
@boegel boegel changed the title fix MS_RDONLY error in OpenMPI 4.0.3 add patch to fix MS_RDONLY error in OpenMPI 4.0.3 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants