Skip to content

{tools}[GCCcore/13.2.0] Jupyter-bundle v20240522, nbclassic v1.0.0, jupyter-server-proxy v4.1.2, ... #20613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lexming
Copy link
Contributor

@lexming lexming commented May 23, 2024

…sic-1.0.0-GCCcore-13.2.0.eb, jupyter-server-proxy-4.1.2-GCCcore-13.2.0.eb, aiohttp-3.9.5-GCCcore-13.2.0.eb, jupyter-resource-usage-1.0.2-GCCcore-13.2.0.eb
@lexming lexming added the update label May 23, 2024
('JupyterNotebook', '7.2.0'),
('nbclassic', '1.0.0'),
('jupyter-server-proxy', '4.1.2'),
# ('jupyterlmod', '5.0.0'), -- not ready yet, waiting for https://github.com/cmd-ntrf/jupyter-lmod/pull/70
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lexming assuming the tests are successful and this is merged as is, you'll come back to this later? or should we simply hold off merging this for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge the bundle without jupyterlmod for the moment. I left the comment so that people know why it is not there compared to the previous bundle. I'll make another PR whenever it is released.

@lexming
Copy link
Contributor Author

lexming commented May 24, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=20613 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20613 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13546

Test results coming soon (I hope)...

- notification for comment with ID 2129005249 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d0e2c6d5fd25b79e18b1c673c0b06aeb for a full test report.

@lexming
Copy link
Contributor Author

lexming commented May 24, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20613 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20613 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4197

Test results coming soon (I hope)...

- notification for comment with ID 2129041372 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/985e8b8a6ce1b793e74b8a478ce9cd9a for a full test report.

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta migueldiascosta added this to the release after 4.9.1 milestone May 24, 2024
@migueldiascosta
Copy link
Member

Going in, thanks @lexming!

@migueldiascosta migueldiascosta merged commit 7a424e9 into easybuilders:develop May 24, 2024
@lexming lexming deleted the 20240523133406_new_pr_Jupyter-bundle20240522 branch May 24, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants