-
Notifications
You must be signed in to change notification settings - Fork 772
{devel}[foss/2023b] TensorFlow v2.15.1, Bazel v6.3.1, flatbuffers-python v23.5.26, ml_dtypes v0.4.0 #21169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
{devel}[foss/2023b] TensorFlow v2.15.1, Bazel v6.3.1, flatbuffers-python v23.5.26, ml_dtypes v0.4.0 #21169
Conversation
…ore-13.2.0.eb, dill-0.3.8-GCCcore-13.2.0.eb, flatbuffers-python-23.5.26-GCCcore-13.2.0.eb, grpcio-1.57.0-GCCcore-13.2.0.eb, ml_dtypes-0.4.0-gfbf-2023b.eb, nsync-1.29.2-GCCcore-13.2.0.eb
|
@tanmoy1989 A bunch of patch files for Bazel are missing? |
|
@boegel: thanks, done! |
easybuild/easyconfigs/m/ml_dtypes/ml_dtypes-0.4.0-gfbf-2023b.eb
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Grund <[email protected]>
| }), | ||
| ('Werkzeug', '3.0.2', { | ||
| 'source_tmpl': SOURCELOWER_TAR_GZ, | ||
| 'source_tmpl': '%(namelower)s-%(version)s.tar.gz', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly the change was not intentional and also not manual. It appeared when I did: "eb --inject-checksums=sha256 --force Tensorflow-2.15.1-foss-2023b.eb" to include the two new patches - probably due to formatting by EasyBuild/Python?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened an issue for that: easybuilders/easybuild-framework#4695
Co-authored-by: Alexander Grund <[email protected]>
Co-authored-by: Alexander Grund <[email protected]>
Co-authored-by: Alexander Grund <[email protected]>
|
Is there any progress on this PR? I would use dill-0.3.8 in my PR. |
|
@boegelbot please test @ generoso |
|
@pavelToman Thanks for triggering the bot. I am not aware of any further progress except me just waiting for someone to review it. |
easybuild/easyconfigs/t/TensorFlow/TensorFlow-2.15.1-foss-2023b.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/t/TensorFlow/TensorFlow-2.15.1-foss-2023b.eb
Outdated
Show resolved
Hide resolved
…b.eb Co-authored-by: Adam Huffman <[email protected]>
…b.eb Co-authored-by: Adam Huffman <[email protected]>
easybuild/easyconfigs/t/TensorFlow/TensorFlow-2.15.1-foss-2023b.eb
Outdated
Show resolved
Hide resolved
…b.eb Co-authored-by: Adam Huffman <[email protected]>
easybuild/easyconfigs/t/TensorFlow/TensorFlow-2.15.1-foss-2023b.eb
Outdated
Show resolved
Hide resolved
…b.eb Co-authored-by: Adam Huffman <[email protected]>
|
Test report by @akesandgren |
…asyconfigs into 20240812155402_new_pr_TensorFlow2151
| 'TensorFlow-2.15.1_fix-pybind11-build.patch', | ||
| 'TensorFlow-2.15.1_fix-AVX512-eigen-compilation.patch', | ||
| 'TensorFlow-2.15.1_fix-AVX512-eigen-compilation-gcc13.patch', | ||
| 'TensorFlow-2.15.1_upgrade-ml_dtypes-dependency-version.patch', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the disable-avx512-extensions.patch
|
@tanmoy1989 And please fix permissions on Bazel-6.3.1_add-symlinks-in-runfiles.patch |
|
@akesandgren thanks, changed the file permission! And also added the patch file on TensorFlow EC as you mentioned. |
|
Doh, you need to update the checksum for Bazel-6.3.1_add-symlinks-in-runfiles.patch since you changed the content, or just re-add that space you removed |
|
Test report by @akesandgren |
|
Test report by @bedroge |
akesandgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I withdraw that approve, you still didn't remove tensorboard from the exts_list replacing grpcio with the external tensorboard |
|
@akesandgren: Sure, just to confirm the things that I need to do:
|
|
@tanmoy1989 Quoting from my previous comment on this: |
|
@akesandgren sorry, I missed that! Hopefully, I have now updated everything! Thanks for checking! |
…asyconfigs into 20240812155402_new_pr_TensorFlow2151
|
Test report by @akesandgren |
easybuild/easyconfigs/t/TensorFlow/TensorFlow-2.15.1-foss-2023b.eb
Outdated
Show resolved
Hide resolved
|
Test report by @akesandgren |
|
Hmmm, since we already have tensorboard 2.18.0 as dependency for other packages in 2023b, can you try changing to that? |
|
Test report by @akesandgren |
|
Ok, TF 2.15 can't use tensorboard 2.18, so we'll need to go back to 2.15.1 and add an exception for that. |
(created using
eb --new-pr)2. Bazel-6.3.1_cc-info.patch file (link)