Skip to content

Conversation

@branfosj
Copy link
Member

@branfosj branfosj commented Apr 17, 2025

Micket
Micket previously approved these changes Apr 17, 2025
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the release after 5.0.0 milestone Apr 17, 2025
@branfosj branfosj marked this pull request as draft April 17, 2025 12:19
@boegel
Copy link
Member

boegel commented Apr 23, 2025

I don't see why this is necessary/useful?

In terms of packaging, nothing really changed in EasyBuild 5.0.0 compared to EasyBuild 4.x?

@boegel
Copy link
Member

boegel commented Apr 23, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--include-easyblocks-from-pr 3700 --installpath /tmp/$USER/pr22774"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22774 EB_ARGS="--include-easyblocks-from-pr 3700 --installpath /tmp/$USER/pr22774" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22774 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6209

Test results coming soon (I hope)...

Details

- notification for comment with ID 2824114456 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3700
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/3c2df3f80ae8a58bb5f276f503421dfa for a full test report.

@Micket
Copy link
Contributor

Micket commented Apr 23, 2025

jwcrypto 1.5.6 requires typing-extensions, which is not installed.

hm, some messed up OS level python-packages on jsc-zen3? I don't see how this change in EB caused this.

@boegel
Copy link
Member

boegel commented Apr 24, 2025

Yeah, pip check with system Python fails with:

jwcrypto 1.5.6 requires typing-extensions, which is not installed.

jwcrypto comes in via a system package:

[kehoste@jsczen3l1 ~]$ rpm -qa | grep jwcryp
python3-jwcrypto-1.5.6-2.el9.noarch

@SebastianAchilles Any ideas here?

We can dance around this by ignoring pip check result when using system Python through an EasyBuild hook (we have similar issues with system-wide Python not passing pip check on our systems in Ghent)

@jfgrimm
Copy link
Member

jfgrimm commented May 21, 2025

@boegel @SebastianAchilles ping

@branfosj
Copy link
Member Author

See the discussion in easybuilders/easybuild-easyblocks#3700 on why this is not a good idea yet. So I'll close this.

However, easybuilders/easybuild-easyblocks#3725 was merged to solve the original issue we were looking to solve with this PR.

@branfosj branfosj closed this May 23, 2025
@branfosj branfosj deleted the 20250417130904_new_pr_EasyBuild500 branch May 23, 2025 08:37
@jfgrimm
Copy link
Member

jfgrimm commented May 23, 2025

Test report by @jfgrimm
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3700
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node034.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/f2898fa3961f9970ec170ae092e9813f for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants