-
Notifications
You must be signed in to change notification settings - Fork 773
{compiler}[GCCcore/14.2.0] glslang-SPIRV v15.3.0 #23171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@boegelbot please test @ jsc-zen3 |
|
Test report by @Crivella |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3008777528 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @Thyre |
|
Test report by @verdurin |
| description = """Glslang is the official reference compiler front end for the OpenGL ES and OpenGL shading languages. | ||
| It implements a strict interpretation of the specifications for these languages. It is open and free for anyone to use, | ||
| either from a command line or programmatically. The OpenGL and OpenGL ES working groups are committed to maintaining | ||
| consistency between the reference compiler and the corresponding shading language specifications.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth mentioning in the description that these SPIRV tools are included, unless you think that would be obvious to anyone loading the module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By following the suggested build procedure https://github.com/KhronosGroup/glslang?tab=readme-ov-file#build-steps, one would normally bring SPIRV in when running update_glslang_sources.py, here we are just bringing them in manually beforehand
|
Test report by @SIB-software |
|
Test report by @Thyre |
|
From discussion on slack, one possibility w.r.t would be to rename this to |
|
Test report by @boegel |
A Please pick something, make the change, since this looks good to go to me otherwise... |
@boegel Was able after trying this again with the newer version to split the 2.
As i mentioned on the thread on slack, this risk for us to have to introduce Would remove the problem of collision between |
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3274529597 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
@boegelbot please test @ jsc-zen3 |
|
Test report by @Crivella |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3274557304 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
easybuild/easyconfigs/g/glslang-spirv/glslang-spirv-15.3.0-GCCcore-14.2.0.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/g/glslang-spirv/glslang-spirv-15.3.0-GCCcore-14.2.0.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/g/glslang-spirv/glslang-spirv-15.3.0-GCCcore-14.2.0.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/g/glslang-spirv/glslang-spirv-15.3.0-GCCcore-14.2.0.eb
Outdated
Show resolved
Hide resolved
…core-14.2.0.eb Co-authored-by: Kenneth Hoste <[email protected]>
|
Test report by @Crivella |
- Move checksums below sources loop - Capitalized `SPIRV`
57ec72a to
a5a22f1
Compare
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3275123222 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @boegel |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Going in, thanks @Crivella! |
Added EC file for glslang
The main aim is to have the dependendency needed for Mesa
The SPIRV part seems to not be needed for it but would be nice to have (still a WIP on that side)
EDIT:
Switched to monolithic build without external dependencies as in