Skip to content

Conversation

@Crivella
Copy link
Contributor

@Crivella Crivella commented Jun 20, 2025

Added EC file for glslang

The main aim is to have the dependendency needed for Mesa

The SPIRV part seems to not be needed for it but would be nice to have (still a WIP on that side)

EDIT:
Switched to monolithic build without external dependencies as in

@Crivella
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3

@Crivella
Copy link
Contributor Author

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/2fad7acd22df724c2b7dae460f2b32f7 for a full test report.

@boegelbot
Copy link
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23171 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23171 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7021

Test results coming soon (I hope)...

Details

- notification for comment with ID 3008777528 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/021935cade3efc8bc4b0a4855d2cbb28 for a full test report.

@Thyre
Copy link
Collaborator

Thyre commented Jul 7, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
Linux - Linux Arch Linux UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x AMD Navi 48 [Radeon RX 9070/9070 XT/9070 GRE] (device id: 0x7550, gfx: gfx1201, driver: 6.15.4-arch2-1), 1 x AMD Raphael (device id: 0x164e, gfx: gfx1036, driver: 6.15.4-arch2-1), Python 3.13.5
See https://gist.github.com/Thyre/fe6a90b8b57162f8fe70e8f60db2df65 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-el8.cloud.in.bmrc.ox.ac.uk - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.11.13
See https://gist.github.com/verdurin/b037d1dc84d745eb2e820c9b15d9af1b for a full test report.

description = """Glslang is the official reference compiler front end for the OpenGL ES and OpenGL shading languages.
It implements a strict interpretation of the specifications for these languages. It is open and free for anyone to use,
either from a command line or programmatically. The OpenGL and OpenGL ES working groups are committed to maintaining
consistency between the reference compiler and the corresponding shading language specifications."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth mentioning in the description that these SPIRV tools are included, unless you think that would be obvious to anyone loading the module?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By following the suggested build procedure https://github.com/KhronosGroup/glslang?tab=readme-ov-file#build-steps, one would normally bring SPIRV in when running update_glslang_sources.py, here we are just bringing them in manually beforehand

@SIB-software
Copy link
Contributor

Test report by @SIB-software
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
chambertin.vital-it.ch - Linux Rocky Linux 8.10, x86_64, Intel(R) Xeon(R) Gold 6230 CPU @ 2.10GHz, Python 3.9.20
See https://gist.github.com/SIB-software/45d19a0265a5923149fdd2948974c553 for a full test report.

@Thyre Thyre added the 2025a issues & PRs related to 2025a common toolchains label Aug 18, 2025
@Thyre
Copy link
Collaborator

Thyre commented Aug 28, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jrc0850.jureca - Linux Rocky Linux 9.5 (Blue Onyx), x86_64, AMD EPYC 7443 24-Core Processor, 8 x AMD AMD Instinct MI250X/MI250 (model: 0x740c, driver: "6.12.12"), Python 3.9.21
See https://gist.github.com/Thyre/c703be3d8f5cab8ac2632799e8be3f7b for a full test report.

@Crivella
Copy link
Contributor Author

Crivella commented Sep 2, 2025

From discussion on slack, one possibility w.r.t

would be to rename this to glslang-spirv as it seems that all the libs/bins shipped by SPIRV-tools are also included here when adding it as an external dep

@boegel boegel changed the title {compiler}[GCCcore/14.2.0] Added EC file for glslang {compiler}[GCCcore/14.2.0] glslang v15.3.0 Sep 2, 2025
@boegel
Copy link
Member

boegel commented Sep 2, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3527.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/5c1dc6d561276153e17f97abdeec8cff for a full test report.

@boegel
Copy link
Member

boegel commented Sep 3, 2025

From discussion on slack, one possibility w.r.t

* [{tools}[GCCcore/14.2.0] SPIRV-tools v2025.1 #23174](https://github.com/easybuilders/easybuild-easyconfigs/pull/23174)

would be to rename this to glslang-spirv as it seems that all the libs/bins shipped by SPIRV-tools are also included here when adding it as an external dep

A -spirv versionsuffix would make sense to me, renaming to glslang-spirv less so.

Please pick something, make the change, since this looks good to go to me otherwise...

@boegel boegel added this to the 5.x milestone Sep 3, 2025
@Crivella Crivella changed the title {compiler}[GCCcore/14.2.0] glslang v15.3.0 {compiler}[GCCcore/14.2.0] glslang v15.3.0 (monolitic) Sep 3, 2025
@Crivella
Copy link
Contributor Author

Crivella commented Sep 3, 2025

Please pick something, make the change, since this looks good to go to me otherwise...

@boegel Was able after trying this again with the newer version to split the 2.

As i mentioned on the thread on slack, this risk for us to have to introduce SPIRV-tools versions that are related to a tag not associated with a release or even a non-tagged commit for this to work.

Would remove the problem of collision between glslang and SPIRV-tools but might make it more difficut to update this in the future

@Crivella
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23171 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23171 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7918

Test results coming soon (I hope)...

Details

- notification for comment with ID 3274529597 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Crivella Crivella changed the title {compiler}[GCCcore/14.2.0] glslang v15.3.0 (monolitic) {compiler}[GCCcore/14.2.0] glslang-spirv v15.3.0 Sep 10, 2025
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/f6c96c5cebdfeedd309b12e0de0ce8bd for a full test report.

@Crivella
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3

@Crivella
Copy link
Contributor Author

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/83d655ae9fd1d3994ab7ebcc6b3497e1 for a full test report.

@boegelbot
Copy link
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23171 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23171 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7919

Test results coming soon (I hope)...

Details

- notification for comment with ID 3274557304 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/4b9aa7577036b9584a2295a00fd51efb for a full test report.

@Crivella Crivella changed the title {compiler}[GCCcore/14.2.0] glslang-spirv v15.3.0 {compiler}[GCCcore/14.2.0] glslang-SPIRV v15.3.0 Sep 10, 2025
@Crivella
Copy link
Contributor Author

Test report by @Crivella
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
crivella-desktop - Linux Ubuntu 22.04.5 LTS (Jammy Jellyfish), x86_64, 13th Gen Intel(R) Core(TM) i9-13900K (skylake), Python 3.11.13
See https://gist.github.com/Crivella/bec5563d67448af82509bd1267524d92 for a full test report.

- Move checksums below sources loop
- Capitalized `SPIRV`
@Crivella
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=23171 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_23171 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7923

Test results coming soon (I hope)...

Details

- notification for comment with ID 3275123222 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/f83187d24fe1f41eb0e4834f97a0f05a for a full test report.

@Crivella Crivella requested a review from boegel September 10, 2025 14:17
@boegel
Copy link
Member

boegel commented Sep 10, 2025

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3590.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/68837f18de4b7b9da49fa99747478d82 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Sep 10, 2025

Going in, thanks @Crivella!

@boegel boegel merged commit 64fc1b9 into easybuilders:develop Sep 10, 2025
8 checks passed
@Crivella Crivella deleted the feature-glslang branch September 10, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2025a issues & PRs related to 2025a common toolchains new ready-to-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants