-
Notifications
You must be signed in to change notification settings - Fork 772
{lang}[GCCcore/6.4.0] Python v3.6.2 #4975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
JackPerdue
wants to merge
2
commits into
easybuilders:develop
from
JackPerdue:20170803163830_new_pr_Python362
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
56 changes: 56 additions & 0 deletions
56
easybuild/easyconfigs/p/Python/Python-3.6.2-GCCcore-6.4.0-bare.eb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| name = 'Python' | ||
| version = '3.6.2' | ||
| versionsuffix = '-bare' | ||
|
|
||
| homepage = 'http://python.org/' | ||
|
|
||
| description = """ | ||
| Python is a programming language that lets you work more quickly and | ||
| integrate your systems more effectively. | ||
|
|
||
| Note: This module is meant to provide a builddependency for other Python | ||
| modules while using EasyBuild's --minimaltoolchain option. Modules | ||
| built with it will require the full Python later | ||
| """ | ||
|
|
||
| toolchain = {'name': 'GCCcore', 'version': '6.4.0'} | ||
| toolchainopts = {'pic': True} | ||
|
|
||
| source_urls = ['http://www.python.org/ftp/%(namelower)s/%(version)s/'] | ||
| sources = [SOURCE_TGZ] | ||
| checksums = ['7919489310a5f17f7acbab64d731e46dca0702874840dadce8bd4b2b3b8e7a82'] | ||
|
|
||
| builddependencies = [ | ||
| ('binutils', '2.28'), | ||
| ] | ||
|
|
||
| dependencies = [ | ||
| ('bzip2', '1.0.6'), | ||
| ('libreadline', '7.0'), | ||
| ('ncurses', '6.0'), | ||
| ('SQLite', '3.19.3'), | ||
| ('zlib', '1.2.11'), | ||
| ] | ||
|
|
||
| osdependencies = [ | ||
| # rely upon distribution for timely security updates | ||
| ('openssl-devel', 'libssl-dev', 'libopenssl-devel'), | ||
| ] | ||
|
|
||
| # We hide this by default since users should not use it in production, | ||
| # high-performance Python should be delivered at compiler level with | ||
| # a default extension set | ||
| # hidden = True | ||
|
|
||
| # bare installation: only known module deps for GCCcore tools included | ||
| exts_list = [] | ||
|
|
||
| # Until such time that EasyBuild accepts 'rpath' as a toolchainopt... | ||
| # add RPATH so this can be used as a builddependency for "bare" PythonPackages | ||
| preconfigopts = """ | ||
| sed -e\ | ||
| 's:LINKFORSHARED) -o $@ Programs/python.o:LINKFORSHARED) -Wl,-rpath=%(installdir)s/lib -o $@ Programs/python.o:'\ | ||
| -i.eb Makefile.pre.in | ||
| """ | ||
|
|
||
| moduleclass = 'lang' | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not start adding (imho) nasty workarounds like this for missing features in the EasyBuild framework...
I have to admit this is a nice way of building pressure for actually implementing support for
rpathas a toolchain option though... ;-)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that EB doesn't update LD_LIBRARY_PATH with builddependencies, then unless the RPATH is set in the python binary, any PythonPackages built on top of it will fail during the sanity check (python -c 'import foo') due to not finding libpythonX.Y.so. I've have 100+ EBs dealing with Python-bare. The EBs in 3.3.1 barely scratch the surface, probably due to this fact. I'm telling you, from experience, if you want to build with --minimal-toolchains then you need the RPATH in python-bare.
I don't care how the RPATH is added, but it needs to be added given the current framework for --minimal-toolchains to be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's any kind of runtime dependency on Python, then Python shouldn't be listed as a build dependency?
So, even with support for
rpathas a toolchain option, I'm not 100% convinced that this is the right way to go.Also relevant: the concept of link dependencies that is yet to be completed in framework, see easybuilders/easybuild-framework#1960