Skip to content

fix names of local variables in i/*/*.eb easyconfigs #8721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2019
Merged

fix names of local variables in i/*/*.eb easyconfigs #8721

merged 1 commit into from
Aug 14, 2019

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 9, 2019

required to avoid warnings when these easyconfigs are parsed because of changed made in easybuilders/easybuild-framework#2938

@boegel boegel added this to the 4.0 milestone Aug 9, 2019
@boegel
Copy link
Member Author

boegel commented Aug 9, 2019

Test report by @boegel
SUCCESS
Build succeeded for 27 out of 27 (27 easyconfigs in this PR)
node2012.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/d8f78714d4f5d60629073d958f200ac0 for a full test report.

Micket
Micket approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Aug 14, 2019

Going in, thanks @boegel!

@Micket Micket merged commit b5788c7 into easybuilders:4.x Aug 14, 2019
@boegel boegel deleted the fix_local_var_naming_i branch August 14, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micket Micket Micket approved these changes

Assignees
No one assigned
Labels
code cleanup
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @Micket