Skip to content

Conversation

@Flamefire
Copy link
Contributor

(created using eb --new-pr)

@boegel
Copy link
Member

boegel commented Nov 11, 2019

(close/re-open to wake up Travis/GitHub Actions to run the tests...)

@boegel boegel closed this Nov 11, 2019
@boegel boegel reopened this Nov 11, 2019
@boegel boegel added the update label Nov 11, 2019
@boegel boegel added this to the next release (4.0.2?) milestone Nov 11, 2019
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Nov 11, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3302.joltik.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz, Python 2.7.5
See https://gist.github.com/6b540c6bb3a5ff3daa9bdf9fbaceba9f for a full test report.

@boegel
Copy link
Member

boegel commented Nov 11, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3209.victini.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/5761a2a0d987e29d38b2326ea85ebd81 for a full test report.

@boegel
Copy link
Member

boegel commented Nov 11, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/28b2734a806448cf4c31f31eb7a1b532 for a full test report.

@boegel
Copy link
Member

boegel commented Nov 11, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2465.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/c259151ef56bfc7e1bcec267526c2fa8 for a full test report.

@boegel
Copy link
Member

boegel commented Nov 11, 2019

Going in, thanks @Flamefire!

@boegel boegel merged commit cb62e74 into easybuilders:develop Nov 11, 2019
@Flamefire Flamefire deleted the 20191111124315_new_pr_Bazel0261 branch November 12, 2019 08:28
@JackPerdue
Copy link
Contributor

On CentOS6 (with python-2.6.6), I had to add Python 2.7 as a builddep.

builddependencies = [('binutils', '2.32'), ('Python', '2.7.16')]

otherwise it failed to build with:

Traceback (most recent call last):
File "/usr/lib64/python2.6/runpy.py", line 122, in _run_module_as_main
"main", fname, loader, pkg_name)
File "/usr/lib64/python2.6/runpy.py", line 34, in _run_code
exec code in run_globals
File "bazel-out/host/bin/src/create_embedded_tools/main.py", line 252, in
File "bazel-out/host/bin/src/create_embedded_tools/main.py", line 181, in Main
File "bazel-out/host/bin/src/create_embedded_tools/main.py", line 132, in CreateModuleSpace
File "bazel-out/host/bin/src/create_embedded_tools/main.py", line 116, in ExtractZip
AttributeError: ZipFile instance has no attribute 'exit'
Target //src:bazel_nojdk failed to build

@Flamefire
Copy link
Contributor Author

Ouch, there is an OS with Python 2.6? Isn't easybuild itself running on 2.7?

According to https://docs.bazel.build/versions/master/install-compile-source.html bazel supports Python 2&3 so I'd rather install Python 3.7.4 as builddependency

@boegel
Copy link
Member

boegel commented Nov 14, 2019

@Flamefire Python 2.6 is the system Python in CentOS 6. We still support running EasyBuild on top of Python 2.6, but not for much longer (we're deprecating that support for the next EasyBuild release, see easybuilders/easybuild-framework#3076).

@JackPerdue Please open an issue on this, it's impossible to keep track of things to do in merged PRs.

@JackPerdue
Copy link
Contributor

Done. #9295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants