Skip to content

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Dec 6, 2019

(created using eb --new-pr)

Fixes #9452

@boegel
Copy link
Member

boegel commented Dec 6, 2019

@Flamefire (or @branfosj) Are you up for submitting a test report for this on a POWER system?

@boegel boegel added the bug fix label Dec 6, 2019
@boegel boegel added this to the release after 4.1.0 (4.1.1?) milestone Dec 6, 2019
@branfosj
Copy link
Member

branfosj commented Dec 7, 2019

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
bear-pg0305u19a.bear.cluster - Linux RHEL 7.6, 8335-GTX, Python 2.7.5
See https://gist.github.com/402b4b115aee14a3e7c6491b04779a75 for a full test report.

@Flamefire
Copy link
Contributor Author

Currently running (again)

Just wanted to highlight the option --disable-headful added which removes X support and therefore the X dependency. IMO for HPC this is OK. I don't really like the e.g. freetype dependency either, and was thinking about adding a dependency on the freetype ECs, but this is a SYSTEM package. Creating a SYSTEM toolchain freetype is also possible but I'm not sure if this can lead to conflicts as jvm/openjdk-1.8.0-internal/jre/lib/ppc64/libfontmanager.so depends on libfreetype.so.6. Was there a similar situation already? How was it solved?

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
taurusml8 - Linux RHEL 7.6, 8335-GTX, Python 2.7.5
See https://gist.github.com/3663e2955401671858ecdbe27aab2c0b for a full test report.

@boegel
Copy link
Member

boegel commented Dec 8, 2019

@Flamefire Adding freetype as a dependency also implies relying on the system compiler to compile freetype (and all its (build) dependencies), which may lead to surprises/problems too.

@branfosj Any objections to the changes made here?

@zao
Copy link
Contributor

zao commented Dec 8, 2019

Just wanted to highlight the option --disable-headful added which removes X support and therefore the X dependency. IMO for HPC this is OK.

Would this be for this particular Java easyconfig or everything?

On our site we install software with GUI components on our windowing-capable login nodes. It's not unfathomable that some of those UIs may be in Java, and it's definitely an aspect of "HPC" that EasyBuild tends to cover.

@branfosj
Copy link
Member

branfosj commented Dec 9, 2019

I'd prefer not adding the --disable-headful. We certainly have applications that are GUI based that we'd make available. Also, this would make this Java different to the other versions available.

@Flamefire
Copy link
Contributor Author

Sure. What would the right osdependencies be in this case? The build suggests You might be able to fix this by running 'sudo yum install libXtst-devel libXt-devel libXrender-devel'.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
taurusml8 - Linux RHEL 7.6, 8335-GTX, Python 2.7.5
See https://gist.github.com/123cc5ef533e8a30d24a5ddccdf28f3e for a full test report.

@boegel
Copy link
Member

boegel commented Dec 10, 2019

Sure. What would the right osdependencies be in this case? The build suggests You might be able to fix this by running 'sudo yum install libXtst-devel libXt-devel libXrender-devel'.

This sounds like at least:

osdependencies = ['libXtst-devel', 'libXt-devel', 'libXrender-devel']

Ideally also the equivalent package name for non-RedHat based Linux distros are added as alternatives by promoting the single string value to a tuple with alternative package names, but I'm not sure that's worth the effort here (is anyone brave enough to use a non RHEL-based distro on POWER)?
Maybe @akesandgren knows the equivalents for Ubuntu/Debian though...

@boegel boegel changed the title Fix missing dependencies on Java 1.8 fix missing OS dependencies in Java 1.8 easyconfig used on POWER systems Dec 10, 2019
@boegel boegel changed the title fix missing OS dependencies in Java 1.8 easyconfig used on POWER systems add missing OS dependencies in Java 1.8 easyconfig used on POWER systems Dec 10, 2019
@akesandgren
Copy link
Contributor

They are:
libxtst-dev, libxt-dev, and libxrender-dev

@Flamefire
Copy link
Contributor Author

Ideally also the equivalent package name for non-RedHat based Linux distros are added as alternatives by promoting the single string value to a tuple with alternative package names

So that would be osdependencies = [..., ('libXtst-devel', 'libxtst-dev'), ...] ?

@boegel
Copy link
Member

boegel commented Dec 13, 2019

Ideally also the equivalent package name for non-RedHat based Linux distros are added as alternatives by promoting the single string value to a tuple with alternative package names

So that would be osdependencies = [..., ('libXtst-devel', 'libxtst-dev'), ...] ?

Exactly.

@Flamefire Flamefire force-pushed the 20191206162120_new_pr_Java18_191b26OpenJDK branch from bb9bd39 to 02dd194 Compare December 16, 2019 13:18
@Flamefire
Copy link
Contributor Author

Ok done. I added the other debian packages too and squashed the commits

@Flamefire Flamefire force-pushed the 20191206162120_new_pr_Java18_191b26OpenJDK branch from 02dd194 to abda90d Compare December 16, 2019 13:20
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
taurusml8 - Linux RHEL 7.6, 8335-GTX, Python 2.7.5
See https://gist.github.com/964739b18fee9b11ad9a82cfa97f8361 for a full test report.

@boegel
Copy link
Member

boegel commented Dec 17, 2019

Going in, thanks @Flamefire!

@boegel boegel merged commit 30ca5e0 into easybuilders:develop Dec 17, 2019
@Flamefire Flamefire deleted the 20191206162120_new_pr_Java18_191b26OpenJDK branch December 17, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing (OS) dependencies for Java-1.8_191-b26-OpenJDK

5 participants