Skip to content

use xorg-macros as dependency in X11 easyconfigs (rather than installing it as a bundle component) #9546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 3 commits into from
Dec 25, 2019
Merged

use xorg-macros as dependency in X11 easyconfigs (rather than installing it as a bundle component) #9546

boegel merged 3 commits into from
Dec 25, 2019

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Dec 18, 2019 •
edited by boegel
Loading

(created using eb --new-pr)

I updated all X11 ECs which have a corresponding xorg-macros EC (as far as I could tell), the other should maybe be archived as most are quite old (e.g. GCC 5)

@Flamefire Flamefire mentioned this pull request Dec 18, 2019
Closed
@Flamefire
Copy link
Contributor Author

Flamefire commented Dec 19, 2019 •
edited by boegel
Loading

@boegel The unit tests seems to not be able to find the patch for libxcb in e.g. X11-20170129-GCCcore-6.3.0.eb and hence fails the test O.o

Edit: Oh, the Bundle easy-block does only add patches checksums but not the patches to its root config. This is a bug: easybuilders/easybuild-easyblocks#1893

@Flamefire Flamefire mentioned this pull request Dec 19, 2019
Closed
@boegel boegel changed the title Use xorg-macros ECs to fix URL errors use xorg-macros as dependency in X11 easyconfigs (rather than installing it as a bundle component) Dec 24, 2019
@boegel boegel added the bug fix label Dec 24, 2019
@boegel boegel added this to the next release (4.1.1) milestone Dec 24, 2019
@easybuilders easybuilders deleted a comment from boegelbot Dec 24, 2019
boegel
boegel approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, test reports coming up...

@boegel
Copy link
Member

boegel commented Dec 24, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2405.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/7d8f4c7758f7384093380fcbe7f772da for a full test report.

@boegel
Copy link
Member

boegel commented Dec 24, 2019

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
node2599.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/08d27661bb74cd1c7969c08cd09a013d for a full test report.

@boegel
Copy link
Member

boegel commented Dec 25, 2019

Going in, thanks @Flamefire!

@boegel boegel merged commit 1aa01fb into easybuilders:develop Dec 25, 2019
@boegel boegel mentioned this pull request Dec 25, 2019
Closed
@Flamefire Flamefire deleted the 20191218180906_new_pr_X1120160819 branch December 25, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@Flamefire @boegel