some easyconfigs broken in 5.0.x due to `keepsymlinks` being enabled by default

[branfosj]

NSS (tested both NSS-3.104-GCCcore-13.3.0.eb and NSS-3.94-GCCcore-13.2.0.eb) fails the sanity check as the install directory has broken symlinks in it.

== sanity checking...
  >> file 'bin/nss-config' found: FAILED
  >> file 'bin/multinit' found: FAILED
  >> file 'lib/libnss.a' found: FAILED

Looking at the install directory, in bin/ we see these:

lrwxrwxrwx 1 branfosj gITS_BEAR_2017-branfosj-rse 30 Mar  5 19:52 nss-config -> ../../../nss/config/nss-config
lrwxrwxrwx 1 branfosj gITS_BEAR_2017-branfosj-rse 92 Mar  5 19:45 nss-policy-check -> ../../../nss/cmd/nss-policy-check/Linux4.18_x86_64_gcc_glibc_PTH_64_OPT.OBJ/nss-policy-check
lrwxrwxrwx 1 branfosj gITS_BEAR_2017-branfosj-rse 89 Mar  5 19:52 nss_bogo_shim -> ../../../nss/gtests/nss_bogo_shim/Linux4.18_x86_64_gcc_glibc_PTH_64_OPT.OBJ/nss_bogo_shim
lrwxrwxrwx 1 branfosj gITS_BEAR_2017-branfosj-rse 76 Mar  5 19:46 ocspclnt -> ../../../nss/cmd/ocspclnt/Linux4.18_x86_64_gcc_glibc_PTH_64_OPT.OBJ/ocspclnt

NSS-3.94-GCCcore-13.2.0.eb was working for me in EB5 in mid January, so we've broken it since then. Specifically: EasyBuild 5.0.0beta1-r52d3f9e638c3dede0bf89c1e746847eb41bcc08e (framework: 5.0.0beta1-r52d3f9e638c3dede0bf89c1e746847eb41bcc08e, easyblocks: 5.0.0beta1-r30dba3532039a26dedaebbe1901c5e5ed26c6f0a).

My initial suspect is:

• enable keeping of symbolic links by default when copying (set keepsymlinks easyconfig parameter to True) #4773

[boegel]

@branfosj Seems like we can simply fix this using keepsymlinks = False in the NSS easyconfigs?

I don't see this as a good enough reason to revert #4773...

[branfosj]

Confirmed that reverting #4773 does fix it:

    'keepsymlinks': [False, ('Boolean to determine whether symlinks are to be kept during copying '
                             'or if the content of the files pointed to should be copied'),

So, potentially anything using files_to_copy may be broken. @boegel tells me there are 717 of those...

[branfosj]

Adding keepsymlinks = False in the NSS easyconfigs also fixes the problem.

edit: see:

• fix NSS easyconfigs by not keeping symlinks when copying files to installation easybuild-easyconfigs#22471

[lexming]

AOCC is also broken due to the change in keepsymlinks. The issue is that AOCC easyblock makes wrappers for the compilers shipped in AOCC and assumes all of them are actual files instead of symlinks.

Fix in

• make AOCC compiler wrappers aware of keepsymlinks option easybuild-easyblocks#3659

[boegel]

I think we can close this, there's no additional known fallout from enabling keepsymlinks by default.

If there is, we can re-open this issue.