-
Notifications
You must be signed in to change notification settings - Fork 211
Subtoolchain searching #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Subtoolchain searching #1306
Changes from all commits
Commits
Show all changes
157 commits
Select commit
Hold shift + click to select a range
9683cda
Added SUBTOOLCHAIN names to intel-para toolchain
49e846b
First effort at searching by subtoolchains...unfinished but number of…
ff4201c
Bit more added to replace_toolchain_with_hierarchy
f4f6dd3
use minimally_resolve_dependencies from main.py
boegel aed1020
Merge pull request #3 from boegel/subtoolchain_searching
90edc95
Some comments
819ef97
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
9eb446d
remove unused build_specs
boegel 53252e0
Merge pull request #4 from boegel/subtoolchain_searching
b232830
More commenting
b9f94ee
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
5878231
make EasyConfig instances comparable and hashable
boegel 23c224f
Merge pull request #5 from boegel/subtoolchain_searching
40655cc
Start building the hierarchy
aaa9fb7
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
b1a56c1
More edits for hierarchy
76c8236
construct subtoolchains dict via search_toolchain, use nub
boegel 858fdb6
Merge pull request #6 from boegel/subtoolchain_searching
e7ebc15
Complete initial subtoolchain support
0ae53db
Update comment
36a420a
Added some resilience and further checking
8301d54
Fixed missing logic in if statement
5568232
Fixed bad logic for subtoolchains
488948f
More logic
47d5e85
Check that everything appears in the final list
4b91fe3
Final logic...now to test
02816d8
Edit
fcfeb1d
Fixed some errors
f70ccbd
Fixed some bugs
93c15ef
Bugs
c616f79
Print bug
cc3dc4a
Bug fixes
3407118
enable 'debug mode', fix KeyError issues
boegel 95b5c6d
Merge pull request #7 from boegel/subtoolchain_searching
d298c2d
Unknown changes!!
6b73c5a
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
5f672f7
fix non-hashable dict issue
boegel d00c1bb
Merge pull request #8 from boegel/subtoolchain_searching
9ca74fe
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
517894e
fix issue with next
boegel 1971d12
Merge pull request #9 from boegel/subtoolchain_searching
dd81f06
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
2c8f0e1
Forgot to add resolved stuff to our list
78c2a6c
moar fixes
boegel 79f8351
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
boegel 7f34a5d
Merge pull request #10 from boegel/subtoolchain_searching
a405d60
moar, MOAR
boegel 9462e9b
Merge pull request #11 from boegel/subtoolchain_searching
bde76ee
Can print out correct files
e122431
don't do parse_only=True
boegel 28ce7cf
Merge pull request #12 from boegel/subtoolchain_searching
5fcca95
works for goalf -> GCC
boegel a297a48
Reverse the order
f8dc095
Added support for dummy toolchain in toolchain list
dbcaf20
undo something that @ocaisa has already tackled
boegel ce2e049
Merge pull request #13 from boegel/subtoolchain_searching
63a373c
Add function to create toolchain hierarchy just from name/version of …
3bd91c8
Ch
b52e019
k
6e78b0b
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
a95edcd
Fix bugs
326ddec
fixes in get_toolchain_hierarchy
boegel d830774
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
boegel 8cf861d
Merge pull request #14 from boegel/subtoolchain_searching
1d44f45
Use newly created function and do not return duplicates
48479dc
First pass at inherently supporting minimal dep resolution
17d3ab4
Some bug fixes
9070b6c
Bug fixed
e4ecd62
Minimise changes. Create new easyconf with updated dependencies and d…
3747817
Fixed some bugs
1fdff0e
Update to minimise changes to original code
017abee
Next stage done but update dependencies not working completely (does …
557e162
Fixed bug
982ed6d
Cleaned up a bit
4983056
Tidy up
03822d0
More tidying
e7d12f3
More tidying
a511872
Added the build options
95d48f5
Typo
fe505a7
Removed exit for testing
9a4f567
Fixed option
2d4f2c0
Fixed deprecated error calls
304a895
Merge branch 'develop' of github.com:hpcugent/easybuild-framework int…
0843dc8
Fixed typo
854d8a3
Fixed bug for the case where dummy is not included in the dependencie…
13632ba
Changed a log to an error since it would cause logic problems otherwise
2ef2d09
Updated all toolchains with their subtoolchains and tidied them up.
d8d32e4
Typo
da5a782
Missed a correction
db1d78e
Give some parsable output for where the original easyconfig came from
8615d74
Merge branch 'develop' into subtoolchain_searching
boegel 74ac45d
Merge pull request #15 from boegel/subtoolchain_searching
4eb3759
Update cgmpolf.py
c69de29
Update cgmpolf.py
48255a3
Update cgmpolf.py
6368766
Merge branch 'develop' into subtoolchain_searching
197ab66
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
d3283ca
Merge branch 'develop' of github.com:ocaisa/easybuild-framework into …
c0289b9
Added newlines where necessary
f4a4a79
Fix key error bug
0e3f517
Use a single directory for all generated easyconfigsx
f3f55fb
Only add dummy to the toolchain hierarchy if requested on the command…
2e64f5b
Attempted to add support for HMNS and subtoolchain searching. It's co…
48ad4f2
Turns out the error is in an easyconfig and the setup works correctly…
b174a35
Remove line
eada415
Add line
b2b5e51
Somtimes dummy has a version, need to allow for this in the hierarchy…
c70a720
Merge branch 'develop' of github.com:ocaisa/easybuild-framework into …
14c0940
Merge branch 'develop' of github.com:ocaisa/easybuild-framework into …
d822c80
Add a simple cache mechanism to the function that generates the toolc…
2f07d13
Removed the simple part :P
d139aae
Set up the cache arguments early and avoid repetition
00d9733
Fix an unresolved reference and a typo
ceb8b07
Remove unnecessary loop
ab66500
add test for EasyConfig comparison & hashing + add __ne__ definition …
boegel 1c66429
include comment w.r.t. implementing both __eq__ and __ne__
boegel 35ef4aa
improve implementation of EasyConfig.__hash__
boegel f236bc9
Merge pull request #17 from boegel/subtoolchain_searching
71a60cd
clean up get_toolchain_hierarchy implementation + add tests
boegel 482e0a3
get rid of log.error
boegel ba6ac6a
Merge pull request #18 from boegel/subtoolchain_searching
a384397
Merge branch 'develop' into subtoolchain_searching
boegel 6bf416c
Merge pull request #19 from boegel/subtoolchain_searching
171424f
Fix a format problem and restrict minimal resolution just to dependen…
599bb7a
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
2923c04
pep8
f7b63e3
cleanup implementation of (deep_)refresh_dependencies and robot_find_…
boegel 01525da
Extract module availability function
fa43c95
Merge pull request #20 from boegel/subtoolchain_searching
09ae683
Fix unresolved refs
625a3d1
REmove unref-ed var
379061e
rename 'unprocessed' to 'easyconfigs' in resolve_dependencies
boegel 118f8d3
fix test that broke due to disabling templating when dumping dependen…
boegel 3767d01
refactor find_resolved_modules and find_minimally_resolved_modules
boegel ab6bcb0
Merge branch 'subtoolchain_searching' of github.com:ocaisa/easybuild-…
boegel 32698b7
remove printing, fix style in main.py
boegel e7ee321
Merge pull request #21 from boegel/subtoolchain_searching
4f7ee7f
Line too long
a4b0366
add test for find_resolved_modules
boegel 76aefd9
don't modify argument passed to robot_find_minimal_easyconfig_for_dep…
boegel 4aa6a3c
add unit test for robot_find_minimal_easyconfig_for_dependency
boegel 4a13d90
fix bugs in find_minimally_resolved_modules
boegel dcf4461
add unit test for find_minimally_resolved_modules
boegel 5581adc
add extra unit test for find_minimally_resolved_modules with also con…
boegel 186d7b5
also define full_mod_name and short_mod_name keys in toolchain dict
boegel ec64a75
fix issues in find_minimally_resolved_modules + rename --use-any-exis…
boegel 111ed29
add new test easyconfig required by tests checking enabling minimal t…
boegel aec6b0b
reverse order of get_toolchain_hierarchy result
boegel dbbf611
require use of --experimental in find_minimally_resolved_modules
boegel 07a052e
allow use of experimental code in robot tests
boegel e5832b2
Merge branches 'develop' and 'subtoolchain_searching' of github.com:o…
0d6f431
Merge pull request #22 from boegel/subtoolchain_searching
cd898d7
define SUBTOOLCHAIN for toolchains where it wasn't yet
boegel df90823
use GCC as subtoolchain for gcccuda toolchain
boegel 6e752a5
Merge pull request #23 from boegel/subtoolchain_searching
89fcbed
fix typo
boegel f8f1bb8
Merge pull request #24 from boegel/subtoolchain_searching
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be implied imho, or maybe the default in
Toolchain
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, more explicit this way