Skip to content

Conversation

@Caylo
Copy link
Contributor

@Caylo Caylo commented Jul 4, 2016

No description provided.

@boegel boegel added this to the v2.9.0 milestone Jul 4, 2016
@boegel boegel changed the title filter subsuite on method name filter test subsuites on method name Jul 4, 2016

return loaded_suite

def filter_tests():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a docstring

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this function accept a list of strings as an argument, rather than grabbing sys.argv here

@boegel boegel modified the milestones: v2.9.0, v2.8.2 Jul 4, 2016
def loadTestsFromTestCase(self, testCaseClass, filters):
"""Return a suite of all tests cases contained in testCaseClass."""

if issubclass(testCaseClass, unittest.TestSuite):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you add this check?

move TestLoaderFiltered to test.framework.utilities, print informative message on test filtering
@boegel
Copy link
Member

boegel commented Jul 5, 2016

@Caylo please add a subsection to http://easybuild.readthedocs.io/en/latest/Unit-tests.html#running explaining how you can filter tests (and include an example, using load on the modules tests is a nice one)

@boegel
Copy link
Member

boegel commented Jul 5, 2016

docs updated via easybuilders/easybuild#234, good to go, thanks @Caylo!

@boegel boegel merged commit 36c341d into easybuilders:develop Jul 5, 2016
@boegel boegel mentioned this pull request Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants