only dump easyconfig with modified deps due to --minimal-toolchains to 'reprod' subdir of install dir #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 'reprod' subdir of install dir
ocaisa
approved these changes
Nov 28, 2016
Member
Author
|
Thanks for the review @ocaisa! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fix for #2025)
This restores dumping of the original easyconfig used to both the easyconfig archive and the
easybuildsubdir of the install directory.The tweaked easyconfig, where dependencies may get assigned a particular subtoolchains (and where template values may have been replaced with the actual value) is still dumped to the
easybuild/reprodsubdir of the install directory, as it was before.The current behaviour, which was introduced in #1614 (EasyBuild v2.7.0) is considered not fully correct, see also https://lists.ugent.be/wws/arc/easybuild/2016-11/msg00063.html .
cc @ocaisa, @JackPerdue, @verdurin