Add goolfc-2.6.10 toolchain for test_get_toolchain_hierarchy robot test. #2464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 4, 2018
test/framework/scripts.py
Outdated
| 'C': '2', # CrayCCE, CUDA | ||
| 'F': '1', # FFTW | ||
| 'G': '6', # GCC, GCCcore, gmvapich2, gompi, goolf, gzip | ||
| 'G': '11', # GCC, GCCcore, gcccuda, gmvapich2, golf, golfc, gompic, gompi, goolf, goolfc, gzip |
There was a problem hiding this comment.
at least two spaces before inline comment
houndci-bot
reviewed
Apr 4, 2018
test/framework/scripts.py
Outdated
| 'C': '2', # CrayCCE, CUDA | ||
| 'F': '1', # FFTW | ||
| 'G': '6', # GCC, GCCcore, gmvapich2, gompi, goolf, gzip | ||
| 'G': '11', # GCC, GCCcore, gcccuda, gmvapich2, golf, golfc, gompic, gompi, goolf, goolfc, gzip |
There was a problem hiding this comment.
at least two spaces before inline comment
akesandgren
reviewed
Aug 27, 2018
| configopts += '--with-cuda=$CUDA_HOME ' # CUDA-aware build; N.B. --disable-dlopen is incompatible | ||
|
|
||
| # needed for --with-verbs | ||
| osdependencies = [('libibverbs-dev', 'libibverbs-devel')] |
Contributor
There was a problem hiding this comment.
Should we add rdma-core-devel to be consistent with how OpenMPI easyconfigs look now adays?
Member
There was a problem hiding this comment.
@akesandgren We could, but it doesn't really matter for these tests, there's little point in keeping the test easyconfigs in sync with the central easyconfigs repo, unless there's a reason for it (e.g. to reproduce a bug or something).
I don't see how having two or three options here matters in any way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goolfc has a more complex subtoolchain hierarchy than goolf/foss so it's useful to test.
I added 2.6.10 because of the existing CUDA test easyconfig, it's all old software but that does not matter really.