Skip to content

Only pay attention to use_existing_modules if we have minimal toolchains #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ocaisa wants to merge 5 commits into from
Closed

Only pay attention to use_existing_modules if we have minimal toolchains #2536

ocaisa wants to merge 5 commits into from

Conversation

@ocaisa
Copy link
Member

@ocaisa ocaisa commented Jul 13, 2018

Fixes #2535 (I hope)

houndci-bot
houndci-bot reviewed Jul 13, 2018
View reviewed changes
@ocaisa ocaisa mentioned this pull request Jul 13, 2018
Closed
@damianam
Copy link
Member

damianam commented Aug 24, 2018

@ocaisa Cray setups typically set use_existing_modules, but I am not sure if they use minimal toolchains. I wonder if your PR might impact them in some way. Should we get someone from CSCS involved? @boegel ?

@boegel
Copy link
Member

boegel commented Aug 24, 2018

cc @gppezzi @victorusu

@boegel boegel added this to the next release milestone Sep 4, 2018
@boegel boegel modified the milestones: 3.7.1, next release Oct 4, 2018
@boegel boegel mentioned this pull request Oct 10, 2018
Closed
@boegel boegel modified the milestones: 3.8.0, 3.9.0 Nov 20, 2018
@boegel
Copy link
Member

boegel commented Dec 13, 2018

superseded by #2690

@boegel boegel closed this Dec 13, 2018
@boegel boegel modified the milestones: 3.9.0, 3.8.0 Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ocaisa @damianam @boegel @houndci-bot