take into account dependency 'wrappers' in check_conflicts #2583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 18, 2018
| pass | ||
| def install_step(self): | ||
| pass | ||
| def sanity_check_step(self): |
| pass | ||
| def build_step(self): | ||
| pass | ||
| def install_step(self): |
| """Dummy implementation of generic easyblock that generates .modulerc files.""" | ||
| def configure_step(self): | ||
| pass | ||
| def build_step(self): |
| """ | ||
| from easybuild.framework.easyblock import EasyBlock | ||
|
|
||
| class ModuleRC(EasyBlock): |
bartoldeman
requested changes
Sep 18, 2018
Contributor
bartoldeman
left a comment
bartoldeman
left a comment
There was a problem hiding this comment.
lgtm, except for the superfluous import (unless I am missing something)
easybuild/tools/robot.py
Outdated
| from easybuild.tools.filetools import det_common_path_prefix, search_file | ||
| from easybuild.tools.module_naming_scheme.easybuild_mns import EasyBuildMNS | ||
| from easybuild.tools.module_naming_scheme.utilities import det_full_ec_version | ||
| from easybuild.tools.toolchain import DUMMY_TOOLCHAIN_NAME |
Contributor
There was a problem hiding this comment.
why was this added but not used later on?
Member
Author
There was a problem hiding this comment.
It was used during an earlier attempt, but that turned out to be too ugly/hacky. I'll clean this up...
boegel
changed the title
bartoldeman
approved these changes
Sep 18, 2018
Contributor
|
going in @boegel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(required for easybuilders/easybuild-easyconfigs#6712)
This fixes a problem with
--check-conflictsreporting false conflicts when an easyconfig that uses the newModuleRCeasyblock is involved (cfr. easybuilders/easybuild-easyblocks#1503).For example:
Because
Java-1.8.ebis a wrapper aroundJava-1.8.0_181.eb,--check-conflictsdetects a conflict where there actually isn't any.