Skip to content

only import from pkg_resources (provided by setuptools) to check GC3Pie version #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akesandgren merged 6 commits into from
Apr 23, 2019
Merged

only import from pkg_resources (provided by setuptools) to check GC3Pie version #2837

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
39b9100
also break 'import pkg_resources' in Travis CI environment
boegel Apr 22, 2019
e272c84
only import from pkg_resources to check GC3Pie version, issue warning…
boegel Apr 22, 2019
60ef5fa
appease the Hound
boegel Apr 22, 2019
60c28d4
check for imports from setuptools via 'grep' rather than breaking imp…
boegel Apr 23, 2019
3028e58
tweak check for setuptools/pkg_resources import statements
boegel Apr 23, 2019
90b658b
don't try to check for import statements that involve tab characters
boegel Apr 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,10 @@ script:
- export PYTHONPATH=/tmp/$TRAVIS_JOB_ID/lib/python$TRAVIS_PYTHON_VERSION/site-packages
# install easybuild-framework to unique temporary location using prepared sdist tarball
- mkdir -p $PYTHONPATH; easy_install --prefix /tmp/$TRAVIS_JOB_ID $TRAVIS_BUILD_DIR/dist/easybuild-framework*tar.gz
# make sure there are no "import setuptools" or "import pkg_resources" statements,
# make sure there are no (top-level) "import setuptools" or "import pkg_resources" statements,
# since EasyBuild should not have a runtime requirement on setuptools
- SETUPTOOLS_IMPORTS=$(egrep -RI '^(from|import) pkg_resources|^(from|import) setuptools' easybuild/ || true)
- test "x$SETUPTOOLS_IMPORTS" = "x" || (echo "Found setuptools imports in easybuild/:\n${SETUPTOOLS_IMPORTS}" && exit 1)
- SETUPTOOLS_IMPORTS=$(egrep -RI '^(from|import)[ \t]*pkg_resources|^(from|import)[ \t]*setuptools' easybuild/ || true)
- test "x$SETUPTOOLS_IMPORTS" = "x" || (echo "Found setuptools and/or pkg_resources imports in easybuild/:\n${SETUPTOOLS_IMPORTS}" && exit 1)
# move outside of checkout of easybuild-framework repository,
# to run tests on an *installed* version of the EasyBuild framework;
# this is done to catch possible packaging issues
Expand Down