correctly resolve template values used for extensions #2852
Conversation
… resolved when extensions are installed
|
@akesandgren While working on this I realized there's another problem with templates like More specifically: templates like The reason for this is that the |
akesandgren
left a comment
akesandgren
left a comment
There was a problem hiding this comment.
A bit difficult to verify by manually looking but LGTM
|
Going in, thanks @boegel! |
| # construct dictionary with template values; | ||
| # inherited from parent, except for name/version templates which are specific to this extension | ||
| template_values = copy.deepcopy(self.cfg.template_values) | ||
| template_values.update(template_constant_dict(ext_src)) |
There was a problem hiding this comment.
Missing an option here, this should be
template_values.update(template_constant_dict(ext_src, skip_lower=False))
3 participants
This fixes a long-standing issue where using templates in
exts_listeither did not work at all, or where incorrect values were being used (i.e. the ones inherited by the 'parent').fixes #1445, #1597, #1138